From: Jeff Johnston <jjohnstn@redhat.com>
To: jdoubleu <hi@jdoubleu.de>
Cc: Newlib <newlib@sourceware.org>
Subject: Re: [PATCH] fix testsuite
Date: Thu, 7 Apr 2022 11:28:32 -0400 [thread overview]
Message-ID: <CAOox84tXJiuopNLnMRURTh_0=y-kURO+tuuPvUseL7H5EJ4Qqg@mail.gmail.com> (raw)
In-Reply-To: <f972305e-f9c6-03ec-fd84-83b06133a47b@jdoubleu.de>
Thanks, patch pushed.
-- Jeff J.
On Thu, Apr 7, 2022 at 5:38 AM jdoubleu <hi@jdoubleu.de> wrote:
> Wasn't sure what to write, since the fix was rather trivial.
>
> Appended a patch with some more description. Please feel free to change
> the commit message, if you think something is still missing.
>
>
> Thanks
> ---
> 🙎🏻♂️ jdoubleu
> On 4/1/2022 3:02 PM, Corinna Vinschen wrote:
> > Hi J,
> >
> > On Mar 24 17:54, jdoubleu wrote:
> >> I found the issue: newlib/testsuite/lib/passfail.exp was using a the
> >> function `newlib_target_compile` which is defined in newlib.exp but
> hasn't
> >> been included yet.
> >>
> >> I attached a patch.
> >>
> >> Still some tests fail to compile, but that seems more like an issue
> with the
> >> host environment or target board.
> >
> > Could you please add the description of the error you're seeing to the
> > commit message of your patch, kind of as in your below first mail?
> > Just "Fix testsuite" is a bit on the terse side :)
> >
> >
> > Thanks,
> > Corinna
> >
prev parent reply other threads:[~2022-04-07 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 15:37 Cannot run testsuite jdoubleu
2022-03-24 16:54 ` [PATCH] fix testsuite jdoubleu
2022-04-01 13:02 ` Corinna Vinschen
2022-04-07 9:38 ` jdoubleu
2022-04-07 15:28 ` Jeff Johnston [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOox84tXJiuopNLnMRURTh_0=y-kURO+tuuPvUseL7H5EJ4Qqg@mail.gmail.com' \
--to=jjohnstn@redhat.com \
--cc=hi@jdoubleu.de \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).