Re: [PATCH] fix testsuite

[jdoubleu <hi@jdoubleu.de>]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

Wasn't sure what to write, since the fix was rather trivial.

Appended a patch with some more description. Please feel free to change 
the commit message, if you think something is still missing.


Thanks
---
🙎🏻‍♂️ jdoubleu
On 4/1/2022 3:02 PM, Corinna Vinschen wrote:
> Hi J,
> 
> On Mar 24 17:54, jdoubleu wrote:
>> I found the issue: newlib/testsuite/lib/passfail.exp was using a the
>> function `newlib_target_compile` which is defined in newlib.exp but hasn't
>> been included yet.
>>
>> I attached a patch.
>>
>> Still some tests fail to compile, but that seems more like an issue with the
>> host environment or target board.
> 
> Could you please add the description of the error you're seeing to the
> commit message of your patch, kind of as in your below first mail?
> Just "Fix testsuite" is a bit on the terse side :)
> 
> 
> Thanks,
> Corinna
> 

[-- Attachment #2: 0001-fix-testsuite-cannot-compile-tests.patch --]
[-- Type: text/plain, Size: 878 bytes --]

From 62a04f3a615d6c2da2277339d3dc60b34b6ac1c7 Mon Sep 17 00:00:00 2001
From: jdoubleu <hi@jdoubleu.de>
Date: Thu, 7 Apr 2022 11:31:40 +0200
Subject: [PATCH] fix testsuite cannot compile tests

DEJAGNU could not find the function 'newlib_target_compile', because it was defined in another file.
---
 newlib/testsuite/lib/passfail.exp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/newlib/testsuite/lib/passfail.exp b/newlib/testsuite/lib/passfail.exp
index 5e7eb21..2c9abf6 100644
--- a/newlib/testsuite/lib/passfail.exp
+++ b/newlib/testsuite/lib/passfail.exp
@@ -4,6 +4,8 @@
 # is freely granted, provided that this notice is preserved.
 #
 
+load_lib newlib.exp
+
 # newlib_pass_fail_all compiles and runs all the source files in the
 # test directory. If flag is -x, then the sources whose basenames are
 # listed in exclude_list are not compiled and run.
-- 
2.35.1