From: Jeff Johnston <jjohnstn@redhat.com>
To: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
Cc: Andrea Corallo <andrea.corallo@arm.com>,
Torbjorn SVENSSON <torbjorn.svensson@st.com>,
"newlib@sourceware.org" <newlib@sourceware.org>
Subject: Re: [PATCH V2] Aarch32/64: Support __FLT_EVAL_METHOD__ values other than 0, 1, 2
Date: Fri, 8 Apr 2022 17:22:48 -0400 [thread overview]
Message-ID: <CAOox84tYSa=UPw8KCth-79hNnLpUqu6e_sme3o=zqJNd-VTNLQ@mail.gmail.com> (raw)
In-Reply-To: <7d0a81fb-4553-a895-1353-97a6af61e6e3@foss.arm.com>
On Fri, Apr 8, 2022 at 6:09 AM Richard Earnshaw <
Richard.Earnshaw@foss.arm.com> wrote:
>
>
> On 04/04/2022 15:53, Andrea Corallo wrote:
> > Torbjorn SVENSSON <torbjorn.svensson@st.com> writes:
> >
> >> Hello,
> >>
> >> It would have been easier to review the patch if it was inline, but
> >> this will have to do anyway.
> >
> > Hi Torbjorn,
> >
> > sorry most mail readers easily show inline attacchaments of type
> > "text/plain" allowing for inline reply, at the same time this way they
> > can still retain the notion of attached file. This is how I rutinary
> > sent my patches to other GNU projects (including GCC) so far. Has
> > newlib some specific rule around this?
> >
> >> I think there is a typo in math.h. Aren't you supposed to do "#ifndef"
> and not "#ifdef"?
> >
> > I guess we are talking about this hunk?
> >
> > #ifdef __epiphany__
> > diff --git a/newlib/libc/include/math.h b/newlib/libc/include/math.h
> > index ba1a8a17e..da056b5b6 100644
> > --- a/newlib/libc/include/math.h
> > +++ b/newlib/libc/include/math.h
> > @@ -158,6 +158,15 @@ extern int isnan (double);
> > #else
> > /* Implementation-defined. Assume float_t and double_t have been
> > * defined previously for this configuration (e.g. config.h). */
> > +
> > + /* If __DOUBLE_TYPE is defined (__FLOAT_TYPE is then supposed to be
> > + defined as well) float_t and double_t definition is suggested by
> > + an arch specific header. */
> > + #ifdef __DOUBLE_TYPE
> > + typedef __DOUBLE_TYPE double_t;
> > + typedef __FLOAT_TYPE float_t;
> > + #endif
> > + /* Assume config.h has provided these types. */
> > #endif
> > #else
> > /* Assume basic definitions. */
> >
> > I believe the #ifdef is correct. As the comment suggests if
> > __DOUBLE_TYPE is defined we'll use it to define double_t otherwise we
> > assume is config.h has provided the type definition.
> >
> > I'm reattaching the latest version of this patch with a typo fixed.
> >
> > Thanks!
> >
> > Andrea
> >
>
> I think the hunks in machine/ieeefp.h warrant a comment as to why we
> can't rely on __FLT_EVAL_METHOD__. Other than that it LGTM, but you'll
> need Corinna or Jeff to approve.
>
> R.
>
>
Please add the comment as suggested by Richard and it will be pushed.
-- Jeff J.
next prev parent reply other threads:[~2022-04-08 21:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 8:39 [PATCH] " Andrea Corallo
2022-04-04 9:32 ` Torbjorn SVENSSON
2022-04-04 14:53 ` [PATCH V2] " Andrea Corallo
2022-04-04 15:12 ` Torbjorn SVENSSON
2022-04-08 10:09 ` Richard Earnshaw
2022-04-08 21:22 ` Jeff Johnston [this message]
2022-04-11 13:52 ` [PATCH V3] " Andrea Corallo
2022-04-11 16:01 ` Jeff Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOox84tYSa=UPw8KCth-79hNnLpUqu6e_sme3o=zqJNd-VTNLQ@mail.gmail.com' \
--to=jjohnstn@redhat.com \
--cc=Richard.Earnshaw@foss.arm.com \
--cc=andrea.corallo@arm.com \
--cc=newlib@sourceware.org \
--cc=torbjorn.svensson@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).