From: Jeff Johnston <jjohnstn@redhat.com>
To: Andrea Corallo <andrea.corallo@arm.com>
Cc: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>,
Torbjorn SVENSSON <torbjorn.svensson@st.com>,
"newlib@sourceware.org" <newlib@sourceware.org>
Subject: Re: [PATCH V3] Aarch32/64: Support __FLT_EVAL_METHOD__ values other than 0, 1, 2
Date: Mon, 11 Apr 2022 12:01:23 -0400 [thread overview]
Message-ID: <CAOox84umoOCsNw9a4pb=QfZbqKPtJ07dp7fc6AOe6dYQq4yt_Q@mail.gmail.com> (raw)
In-Reply-To: <gkrsfqjwwvf.fsf_-_@arm.com>
Thanks Andrea. Patch pushed to master.
-- Jeff J.
On Mon, Apr 11, 2022 at 9:52 AM Andrea Corallo <andrea.corallo@arm.com>
wrote:
> Jeff Johnston <jjohnstn@redhat.com> writes:
>
> >> On Fri, Apr 8, 2022 at 6:09 AM Richard Earnshaw <mailto:
> Richard.Earnshaw@foss.arm.com> wrote:
> >>
> >> I think the hunks in machine/ieeefp.h warrant a comment as to why we
> >> can't rely on __FLT_EVAL_METHOD__. Other than that it LGTM, but you'll
> >> need Corinna or Jeff to approve.
> >
> > R.
> > Please add the comment as suggested by Richard and it will be pushed.--
> Jeff J.
>
> Hi all,
>
> please find attached the updated version of the patch implementing
> Richard's suggestion.
>
> Best Regards
>
> Andrea
>
> PS I've no write access to newlib's repo so feel free to push it if
> okay.
>
>
prev parent reply other threads:[~2022-04-11 16:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 8:39 [PATCH] " Andrea Corallo
2022-04-04 9:32 ` Torbjorn SVENSSON
2022-04-04 14:53 ` [PATCH V2] " Andrea Corallo
2022-04-04 15:12 ` Torbjorn SVENSSON
2022-04-08 10:09 ` Richard Earnshaw
2022-04-08 21:22 ` Jeff Johnston
2022-04-11 13:52 ` [PATCH V3] " Andrea Corallo
2022-04-11 16:01 ` Jeff Johnston [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOox84umoOCsNw9a4pb=QfZbqKPtJ07dp7fc6AOe6dYQq4yt_Q@mail.gmail.com' \
--to=jjohnstn@redhat.com \
--cc=Richard.Earnshaw@foss.arm.com \
--cc=andrea.corallo@arm.com \
--cc=newlib@sourceware.org \
--cc=torbjorn.svensson@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).