From: Jeff Johnston <jjohnstn@redhat.com>
To: Alexey Lapshin <alexey.lapshin@espressif.com>
Cc: Alexey Gerenkov <alexey.gerenkov@espressif.com>,
"newlib@sourceware.org" <newlib@sourceware.org>,
"jcmvbkbc@gmail.com" <jcmvbkbc@gmail.com>,
Ivan Grokhotkov <ivan@espressif.com>
Subject: Re: [PATCH, RFC v3 0/3] add xtensa port
Date: Tue, 15 Aug 2023 18:09:58 -0400 [thread overview]
Message-ID: <CAOox84v6oOMCDrJraQ1zw2PcvgkOYmhXrB7WVji_9h8KL3g1Lg@mail.gmail.com> (raw)
In-Reply-To: <ed8a5763a546de22d18565c89dc47ed96f8028a2.camel@espressif.com>
[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]
Looks better. I notice that in your previous patches you tweaked the code
in Makefile.am from the original patch 1 which I applied. In the
previous patch2 you had:
diff --git a/newlib/Makefile.am b/newlib/Makefile.am
index 126cf24c1..e29607ccd 100644
--- a/newlib/Makefile.am
+++ b/newlib/Makefile.am
@@ -240,7 +240,7 @@ stmp-targ-include: config.status
$(AM_V_at)s=machine/$(machine_dir)/include d= $(TARG_INCLUDE_CP_DIR)
$(AM_V_at)s=sys/$(sys_dir)/include d= $(TARG_INCLUDE_CP_DIR)
$(AM_V_at)for i in $(call
rwildcard,$(srcdir)/libc/sys/$(sys_dir)/include/,*.h); do \
- f=`echo $$i | sed s:$(srcdir)/libc/sys/$(sys_dir)/include/::`; \
+ f=`echo $$i | sed s:^$(srcdir)/libc/sys/$(sys_dir)/include/::`; \
$(MKDIR_P) targ-include/`dirname $$f`; \
cp $$i targ-include/$$f; \
done
@@ -334,7 +334,7 @@ install-data-local: install-toollibLIBRARIES
install-multi $(INSTALL_DATA_LOCAL)
else true; fi ; \
done ; \
for i in $(call
rwildcard,$(srcdir)/libc/sys/$(sys_dir)/include/,*.h); do \
- f=`echo $$i | sed s:$(srcdir)/libc/sys/$(sys_dir)/include/::`; \
+ f=`echo $$i | sed s:^$(srcdir)/libc/sys/$(sys_dir)/include/::`;
\
$(MKDIR_P) $(DESTDIR)$(tooldir)/`dirname $$f`; \
$(INSTALL_DATA) $$i $(DESTDIR)$(tooldir)/`dirname $$f`; \
done ; \
Is this change required and is missing from this latest Patch 2 or did you
change your mind regarding the change?
-- Jeff J.
On Tue, Aug 15, 2023 at 3:20 PM Alexey Lapshin <alexey.lapshin@espressif.com>
wrote:
> Ahh, yes, sorry for that, resending
>
next prev parent reply other threads:[~2023-08-15 22:10 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 6:03 [PATCH, RFC 0/8] " Alexey Lapshin
2023-05-11 6:05 ` [PATCH, RFC 1/8] newlib: add system headers from include/$(sys_dir)/*/*.h Alexey Lapshin
2023-05-11 6:12 ` [PATCH, RFC 2/8] libc: sys: add xtensa port Alexey Lapshin
2023-05-11 6:18 ` [PATCH, RFC 3/8] libm: " Alexey Lapshin
2023-05-11 6:20 ` [PATCH, RFC 4/8] libc: " Alexey Lapshin
2023-05-11 6:21 ` [PATCH, RFC 5/8] libm: add attribute weak for __ieee754_sqrtf Alexey Lapshin
2023-05-11 6:22 ` [PATCH, RFC 6/8] libgloss: libnosys: add xtensa port Alexey Lapshin
2023-05-11 6:23 ` [PATCH, RFC 7/8] libgloss: " Alexey Lapshin
2023-05-11 6:25 ` [PATCH, RFC 8/8] libc: fix xtensa PSRAM cache bug Alexey Lapshin
2023-05-12 9:18 ` [PATCH, RFC 0/8] add xtensa port Max Filippov
2023-05-15 13:45 ` [PATCH, RFC v2 " Alexey Lapshin
2023-05-15 13:47 ` [PATCH, RFC v2 1/8] newlib: add system headers from include/$(sys_dir)/*/*.h Alexey Lapshin
2023-05-15 13:48 ` [PATCH, RFC v2 2/8] libc: sys: add xtensa port Alexey Lapshin
2023-05-15 13:49 ` [PATCH, RFC v2 3/8] libm: " Alexey Lapshin
2023-05-15 13:50 ` [PATCH, RFC v2 4/8] libc: " Alexey Lapshin
2023-05-15 13:51 ` [PATCH, RFC v2 5/8] libm: add attribute weak for __ieee754_sqrtf Alexey Lapshin
2023-05-15 13:53 ` [PATCH, RFC v2 6/8] libgloss: libnosys: add xtensa port Alexey Lapshin
2023-05-15 13:54 ` [PATCH, RFC v2 7/8] libgloss: " Alexey Lapshin
2023-05-15 13:55 ` [PATCH, RFC v2 8/8] libc: xtensa: fix PSRAM cache bug Alexey Lapshin
2023-05-30 19:58 ` [PATCH, RFC v2 0/8] add xtensa port Jeff Johnston
2023-05-31 7:53 ` Alexey Lapshin
2023-08-09 20:00 ` [PATCH, RFC v3 0/3] " Alexey Lapshin
2023-08-09 20:02 ` [PATCH, RFC v3 1/3] libc: fix nested sys-include dirs install Alexey Lapshin
2023-08-09 20:03 ` [PATCH, RFC v3 2/3] newlib: add Xtensa port Alexey Lapshin
2023-08-09 20:04 ` [PATCH, RFC v3 3/3] libgloss: " Alexey Lapshin
2023-08-10 18:20 ` [PATCH, RFC v3 0/3] add xtensa port Jeff Johnston
2023-08-10 19:50 ` Alexey Lapshin
2023-08-10 22:12 ` Jeff Johnston
2023-08-10 22:15 ` Alexey Lapshin
2023-08-10 22:18 ` Jeff Johnston
2023-08-15 7:20 ` Alexey Lapshin
2023-08-15 14:48 ` Jeff Johnston
2023-08-15 15:07 ` Alexey Lapshin
2023-08-15 17:53 ` Jeff Johnston
2023-08-15 19:20 ` Alexey Lapshin
2023-08-15 22:09 ` Jeff Johnston [this message]
2023-08-16 7:46 ` Alexey Lapshin
2023-08-16 18:55 ` Jeff Johnston
2023-08-17 20:38 ` Alexey Lapshin
2023-08-17 22:25 ` Jeff Johnston
2023-08-18 10:13 ` Alexey Lapshin
2023-08-23 20:57 ` Jeff Johnston
2023-08-23 21:28 ` Alexey Lapshin
2023-08-24 15:01 ` Jeff Johnston
2023-08-24 15:45 ` Alexey Lapshin
2023-09-11 12:07 ` [PATCH, RFC 0/8] " Sebastian Huber
2023-09-11 12:15 ` Alexey Lapshin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOox84v6oOMCDrJraQ1zw2PcvgkOYmhXrB7WVji_9h8KL3g1Lg@mail.gmail.com \
--to=jjohnstn@redhat.com \
--cc=alexey.gerenkov@espressif.com \
--cc=alexey.lapshin@espressif.com \
--cc=ivan@espressif.com \
--cc=jcmvbkbc@gmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).