Newlib/libgloss port for RISC-V

Newlib/libgloss port for RISC-V

[Kito Cheng]

Hi all:

We'd like to contribute for RISC-V[1] support to newlib/libgloss.
RISC-V is an open ISA which support both 32 and 64 bit.

For the other part of GNU toolchain, GCC and binutils already included
in upstream in GCC 7 / binutils 2.28.

We've also tested with newlib and gcc testsuite for following targets:

riscv32-unknown-elf
riscv64-unknown-elf

[PATCH 1/3] Add RISC-V port for newlib
https://sourceware.org/ml/newlib/2017/msg00669.html
[PATCH 2/3] Add RISC-V port for libm
https://sourceware.org/ml/newlib/2017/msg00670.html
[PATCH 3/3] Add RISC-V port for libgloss
https://sourceware.org/ml/newlib/2017/msg00671.html

Contributor list:
   - Andrew Waterman  <andrew@sifive.com>
   - Kito Cheng  <kito.cheng@gmail.com>
   - Palmer Dabbelt  <palmer@dabbelt.com>
   - Scott Beamer  <sbeamer@eecs.berkeley.edu>
   - Michael Neilly  <mneilly@yahoo.com>
   - Alex Suykov  <alex.suykov@gmail.com>


[1] https://riscv.org/

Re: Newlib/libgloss port for RISC-V

[Jeff Johnston]

Hi Kito,

Before I continue reviewing, I have noticed that you have no licensing
information in any of your non-generated files.  You need to add this
as Red Hat has
the default license.  You can make it BSD-like or see other licenses
in the repository that are even more permissive.  That said, you have
another issue in that one of your files (asm.h) in the first patch has
been taken from glibc and is LPGL.  This can cause problems unless you
are building newlib as a dynamic library as code that links to your
library becomes LGPL unless it provides everything required to relink.
  See:  https://stackoverflow.com/questions/10130143/gpl-lgpl-and-static-linking

My suggestion would be to create your own version of asm.h and any
other files that are LGPL and license them how you see fit.

Regards,

-- Jeff J.

On Thu, Jul 27, 2017 at 5:29 AM, Kito Cheng <kito.cheng@gmail.com> wrote:
> Hi all:
>
> We'd like to contribute for RISC-V[1] support to newlib/libgloss.
> RISC-V is an open ISA which support both 32 and 64 bit.
>
> For the other part of GNU toolchain, GCC and binutils already included
> in upstream in GCC 7 / binutils 2.28.
>
> We've also tested with newlib and gcc testsuite for following targets:
>
> riscv32-unknown-elf
> riscv64-unknown-elf
>
> [PATCH 1/3] Add RISC-V port for newlib
> https://sourceware.org/ml/newlib/2017/msg00669.html
> [PATCH 2/3] Add RISC-V port for libm
> https://sourceware.org/ml/newlib/2017/msg00670.html
> [PATCH 3/3] Add RISC-V port for libgloss
> https://sourceware.org/ml/newlib/2017/msg00671.html
>
> Contributor list:
>    - Andrew Waterman  <andrew@sifive.com>
>    - Kito Cheng  <kito.cheng@gmail.com>
>    - Palmer Dabbelt  <palmer@dabbelt.com>
>    - Scott Beamer  <sbeamer@eecs.berkeley.edu>
>    - Michael Neilly  <mneilly@yahoo.com>
>    - Alex Suykov  <alex.suykov@gmail.com>
>
>
> [1] https://riscv.org/

Re: [patches] Re: Newlib/libgloss port for RISC-V

[Kito Cheng]

Hi Jeff:

Thanks for your review, we'll review and add the licensing
information for every file again and update the patch set.

On Tue, Aug 1, 2017 at 1:34 AM, Jeff Johnston <jjohnstn@redhat.com> wrote:
> Hi Kito,
>
> Before I continue reviewing, I have noticed that you have no licensing
> information in any of your non-generated files.  You need to add this
> as Red Hat has
> the default license.  You can make it BSD-like or see other licenses
> in the repository that are even more permissive.  That said, you have
> another issue in that one of your files (asm.h) in the first patch has
> been taken from glibc and is LPGL.  This can cause problems unless you
> are building newlib as a dynamic library as code that links to your
> library becomes LGPL unless it provides everything required to relink.
>   See:  https://stackoverflow.com/questions/10130143/gpl-lgpl-and-static-linking
>
> My suggestion would be to create your own version of asm.h and any
> other files that are LGPL and license them how you see fit.
>
> Regards,
>
> -- Jeff J.
>
> On Thu, Jul 27, 2017 at 5:29 AM, Kito Cheng <kito.cheng@gmail.com> wrote:
>> Hi all:
>>
>> We'd like to contribute for RISC-V[1] support to newlib/libgloss.
>> RISC-V is an open ISA which support both 32 and 64 bit.
>>
>> For the other part of GNU toolchain, GCC and binutils already included
>> in upstream in GCC 7 / binutils 2.28.
>>
>> We've also tested with newlib and gcc testsuite for following targets:
>>
>> riscv32-unknown-elf
>> riscv64-unknown-elf
>>
>> [PATCH 1/3] Add RISC-V port for newlib
>> https://sourceware.org/ml/newlib/2017/msg00669.html
>> [PATCH 2/3] Add RISC-V port for libm
>> https://sourceware.org/ml/newlib/2017/msg00670.html
>> [PATCH 3/3] Add RISC-V port for libgloss
>> https://sourceware.org/ml/newlib/2017/msg00671.html
>>
>> Contributor list:
>>    - Andrew Waterman  <andrew@sifive.com>
>>    - Kito Cheng  <kito.cheng@gmail.com>
>>    - Palmer Dabbelt  <palmer@dabbelt.com>
>>    - Scott Beamer  <sbeamer@eecs.berkeley.edu>
>>    - Michael Neilly  <mneilly@yahoo.com>
>>    - Alex Suykov  <alex.suykov@gmail.com>
>>
>>
>> [1] https://riscv.org/
>
> --
> You received this message because you are subscribed to the Google Groups "RISC-V Patches" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to patches+unsubscribe@groups.riscv.org.
> To post to this group, send email to patches@groups.riscv.org.
> Visit this group at https://groups.google.com/a/groups.riscv.org/group/patches/.
> To view this discussion on the web visit https://groups.google.com/a/groups.riscv.org/d/msgid/patches/CAOox84vm6%2BnCNSa1aDROUJgXJMentreipYYfyTk%2BuBk2X-t4Lw%40mail.gmail.com.
> For more options, visit https://groups.google.com/a/groups.riscv.org/d/optout.