* [PATCH] Remove unneccesary parenthesis around declarator
@ 2021-07-22 21:41 Maxim Blinov
2021-07-23 2:14 ` [PATCH] Remove unnecessary parentheses " Brian Inglis
2021-07-28 9:33 ` [PATCH] Remove unneccesary parenthesis " Corinna Vinschen
0 siblings, 2 replies; 5+ messages in thread
From: Maxim Blinov @ 2021-07-22 21:41 UTC (permalink / raw)
To: newlib; +Cc: Maxim Blinov
riscv64-unknown-elf-g++-11.1.0 regression suite reports the following
failures for
$ make check-gcc-c++ RUNTESTFLAGS='dg.exp=Wstringop-overflow-6.C'
```
FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++14 (test for excess errors)
FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++17 (test for excess errors)
FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++2a (test for excess errors)
UNSUPPORTED: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++98
```
The "excess errors" being
```
output is In file included from /home/maxim/prj/riscv-upstream/install/riscv64-unknown-elf/include/wchar.h:6,
from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/cwchar:44,
from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/bits/postypes.h:40,
from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/iosfwd:40,
from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/ios:38,
from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/ostream:38,
from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/iostream:39,
from /home/maxim/prj/riscv-upstream/gcc-11.1.0/gcc/testsuite/g++.dg/warn/Wstringop-overflow-6.C:6:
/home/maxim/prj/riscv-upstream/install/riscv64-unknown-elf/include/sys/reent.h:685:11: warning: unnecessary parentheses in declaration of '_sig_func' [-Wparentheses]
```
---
newlib/libc/include/sys/reent.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newlib/libc/include/sys/reent.h b/newlib/libc/include/sys/reent.h
index 6e55e1c1f..34aff863a 100644
--- a/newlib/libc/include/sys/reent.h
+++ b/newlib/libc/include/sys/reent.h
@@ -677,7 +677,7 @@ struct _reent
# endif
/* signal info */
- void (**(_sig_func))(int);
+ void (**_sig_func)(int);
/* These are here last so that __FILE can grow without changing the offsets
of the above members (on the off chance that future binary compatibility
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Remove unnecessary parentheses around declarator
2021-07-22 21:41 [PATCH] Remove unneccesary parenthesis around declarator Maxim Blinov
@ 2021-07-23 2:14 ` Brian Inglis
2021-07-28 9:33 ` [PATCH] Remove unneccesary parenthesis " Corinna Vinschen
1 sibling, 0 replies; 5+ messages in thread
From: Brian Inglis @ 2021-07-23 2:14 UTC (permalink / raw)
To: newlib
On 2021-07-22 15:41, Maxim Blinov wrote:
> riscv64-unknown-elf-g++-11.1.0 regression suite reports the following
> failures for
>
> $ make check-gcc-c++ RUNTESTFLAGS='dg.exp=Wstringop-overflow-6.C'
>
> ```
> FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++14 (test for excess errors)
> FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++17 (test for excess errors)
> FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++2a (test for excess errors)
> UNSUPPORTED: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++98
> ```
>
> The "excess errors" being
>
> ```
> output is In file included from /home/maxim/prj/riscv-upstream/install/riscv64-unknown-elf/include/wchar.h:6,
> from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/cwchar:44,
> from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/bits/postypes.h:40,
> from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/iosfwd:40,
> from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/ios:38,
> from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/ostream:38,
> from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/iostream:39,
> from /home/maxim/prj/riscv-upstream/gcc-11.1.0/gcc/testsuite/g++.dg/warn/Wstringop-overflow-6.C:6:
> /home/maxim/prj/riscv-upstream/install/riscv64-unknown-elf/include/sys/reent.h:685:11: warning: unnecessary parentheses in declaration of '_sig_func' [-Wparentheses]
> ```
> ---
> newlib/libc/include/sys/reent.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/newlib/libc/include/sys/reent.h b/newlib/libc/include/sys/reent.h
> index 6e55e1c1f..34aff863a 100644
> --- a/newlib/libc/include/sys/reent.h
> +++ b/newlib/libc/include/sys/reent.h
> @@ -677,7 +677,7 @@ struct _reent
> # endif
>
> /* signal info */
> - void (**(_sig_func))(int);
> + void (**_sig_func)(int);
>
> /* These are here last so that __FILE can grow without changing the offsets
> of the above members (on the off chance that future binary compatibility
>
Such "unnecessary" parentheses are often specified to force functions to
be called and disallow macro substitution.
--
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in binary units and prefixes, physical quantities in SI.]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Remove unneccesary parenthesis around declarator
2021-07-22 21:41 [PATCH] Remove unneccesary parenthesis around declarator Maxim Blinov
2021-07-23 2:14 ` [PATCH] Remove unnecessary parentheses " Brian Inglis
@ 2021-07-28 9:33 ` Corinna Vinschen
2021-07-28 18:48 ` R. Diez
1 sibling, 1 reply; 5+ messages in thread
From: Corinna Vinschen @ 2021-07-28 9:33 UTC (permalink / raw)
To: newlib
On Jul 22 22:41, Maxim Blinov wrote:
> riscv64-unknown-elf-g++-11.1.0 regression suite reports the following
> failures for
>
> $ make check-gcc-c++ RUNTESTFLAGS='dg.exp=Wstringop-overflow-6.C'
>
> ```
> FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++14 (test for excess errors)
> FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++17 (test for excess errors)
> FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++2a (test for excess errors)
> UNSUPPORTED: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++98
> ```
>
> The "excess errors" being
>
> ```
> output is In file included from /home/maxim/prj/riscv-upstream/install/riscv64-unknown-elf/include/wchar.h:6,
> from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/cwchar:44,
> from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/bits/postypes.h:40,
> from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/iosfwd:40,
> from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/ios:38,
> from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/ostream:38,
> from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/iostream:39,
> from /home/maxim/prj/riscv-upstream/gcc-11.1.0/gcc/testsuite/g++.dg/warn/Wstringop-overflow-6.C:6:
> /home/maxim/prj/riscv-upstream/install/riscv64-unknown-elf/include/sys/reent.h:685:11: warning: unnecessary parentheses in declaration of '_sig_func' [-Wparentheses]
> ```
> ---
> newlib/libc/include/sys/reent.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/newlib/libc/include/sys/reent.h b/newlib/libc/include/sys/reent.h
> index 6e55e1c1f..34aff863a 100644
> --- a/newlib/libc/include/sys/reent.h
> +++ b/newlib/libc/include/sys/reent.h
> @@ -677,7 +677,7 @@ struct _reent
> # endif
>
> /* signal info */
> - void (**(_sig_func))(int);
> + void (**_sig_func)(int);
>
> /* These are here last so that __FILE can grow without changing the offsets
> of the above members (on the off chance that future binary compatibility
> --
> 2.17.1
Pushed.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Remove unneccesary parenthesis around declarator
2021-07-28 9:33 ` [PATCH] Remove unneccesary parenthesis " Corinna Vinschen
@ 2021-07-28 18:48 ` R. Diez
2021-07-29 9:24 ` Corinna Vinschen
0 siblings, 1 reply; 5+ messages in thread
From: R. Diez @ 2021-07-28 18:48 UTC (permalink / raw)
To: Corinna Vinschen; +Cc: newlib
> On Jul 22 22:41, Maxim Blinov wrote:
>> riscv64-unknown-elf-g++-11.1.0 regression suite reports the following
>> failures for
>>
>> /home/maxim/prj/riscv-upstream/install/riscv64-unknown-elf/include/sys/reent.h:685:11:
>> warning: unnecessary parentheses in declaration of '_sig_func' [-Wparentheses]
> Pushed.
That is one type of warning that I was trying to fix with this patch:
[PATCH 0/1] Fix some warnings in the public headers
https://sourceware.org/pipermail/newlib/2021/018316.html
Maybe you'd like to take a look now. I bet some of the warning fixes still apply.
Regards,
rdiez
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Remove unneccesary parenthesis around declarator
2021-07-28 18:48 ` R. Diez
@ 2021-07-29 9:24 ` Corinna Vinschen
0 siblings, 0 replies; 5+ messages in thread
From: Corinna Vinschen @ 2021-07-29 9:24 UTC (permalink / raw)
To: R. Diez; +Cc: newlib
On Jul 28 20:48, R. Diez via Newlib wrote:
> > On Jul 22 22:41, Maxim Blinov wrote:
> > > riscv64-unknown-elf-g++-11.1.0 regression suite reports the following
> > > failures for
> > >
> > > /home/maxim/prj/riscv-upstream/install/riscv64-unknown-elf/include/sys/reent.h:685:11:
> > > warning: unnecessary parentheses in declaration of '_sig_func' [-Wparentheses]
>
> > Pushed.
>
> That is one type of warning that I was trying to fix with this patch:
>
> [PATCH 0/1] Fix some warnings in the public headers
>
> https://sourceware.org/pipermail/newlib/2021/018316.html
>
> Maybe you'd like to take a look now. I bet some of the warning fixes still apply.
Could you just send a new patchset, please?
Thanks,
Corinna
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-29 9:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 21:41 [PATCH] Remove unneccesary parenthesis around declarator Maxim Blinov
2021-07-23 2:14 ` [PATCH] Remove unnecessary parentheses " Brian Inglis
2021-07-28 9:33 ` [PATCH] Remove unneccesary parenthesis " Corinna Vinschen
2021-07-28 18:48 ` R. Diez
2021-07-29 9:24 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).