From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH 1/2] newlib: move to ../config/multi.m4 for multilib logic
Date: Fri, 21 Jan 2022 14:26:02 +0100 [thread overview]
Message-ID: <Yeq0asbtB3+0AdJZ@calimero.vinschen.de> (raw)
In-Reply-To: <Yeqkc2cYT2SanCIM@vapier>
On Jan 21 07:17, Mike Frysinger wrote:
> On 21 Jan 2022 12:23, Corinna Vinschen wrote:
> > On Jan 20 22:58, Mike Frysinger wrote:
> > > The current newlib multilib logic is almost exactly the same as the
> > > config/multi.m4, and the differences should be minor, so switch over
> > > to that to delete custom logic on ourside.
> >
> > What differences are that?
>
> the differences don't affect the actual compilation.
>
> newlib/configure.ac uses AC_CONFIG_FILES to hack up Makefile. multi.m4
> uses AC_OUTPUT_COMMANDS instead.
>
> newlib/configure.ac passes LDFLAGS to init-cmds while multi.m4 does not
> (it does pass additional non-C toolchain vars that newlib doesn't use).
> afaict omitting LDFLAGS shouldn't make a diff since newlib has been
> clobbering that with an invalid setting ($ldflags).
>
> there's also a few internal variable names that changed, but since newlib
> doesn't check them, it shouldn't matter.
>
> > Did you check them?
>
> yes, i've build every commit against bfin-elf multilib. if you want me
> to check something specifically, please highlight it.
> -mike
No it's fine. I just checked again Cygwin which still works,
apparently. Please push.
Thanks,
Corinna
prev parent reply other threads:[~2022-01-21 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 3:58 Mike Frysinger
2022-01-21 3:58 ` [PATCH 2/2] newlib: stop checking --enable-multilib in subdirs Mike Frysinger
2022-01-21 11:23 ` [PATCH 1/2] newlib: move to ../config/multi.m4 for multilib logic Corinna Vinschen
2022-01-21 12:17 ` Mike Frysinger
2022-01-21 13:26 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yeq0asbtB3+0AdJZ@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).