Re: [PATCH 1/2] newlib: move to ../config/multi.m4 for multilib logic

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

On 21 Jan 2022 12:23, Corinna Vinschen wrote:
> On Jan 20 22:58, Mike Frysinger wrote:
> > The current newlib multilib logic is almost exactly the same as the
> > config/multi.m4, and the differences should be minor, so switch over
> > to that to delete custom logic on ourside.
> 
> What differences are that?

the differences don't affect the actual compilation.

newlib/configure.ac uses AC_CONFIG_FILES to hack up Makefile.  multi.m4
uses AC_OUTPUT_COMMANDS instead.

newlib/configure.ac passes LDFLAGS to init-cmds while multi.m4 does not
(it does pass additional non-C toolchain vars that newlib doesn't use).
afaict omitting LDFLAGS shouldn't make a diff since newlib has been
clobbering that with an invalid setting ($ldflags).

there's also a few internal variable names that changed, but since newlib
doesn't check them, it shouldn't matter.

> Did you check them?

yes, i've build every commit against bfin-elf multilib.  if you want me
to check something specifically, please highlight it.
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]