From: Corinna Vinschen <vinschen@redhat.com>
To: newlib@sourceware.org
Subject: Re: [PATCH] newlib: stop clobbering LDFLAGS with non-standard $ldflags
Date: Fri, 21 Jan 2022 12:25:45 +0100 [thread overview]
Message-ID: <YeqYOfGhyfR5D3Cg@calimero.vinschen.de> (raw)
In-Reply-To: <20220121045152.21131-1-vapier@gentoo.org>
On Jan 20 23:51, Mike Frysinger wrote:
> It's unclear why this was added originally, but assuming it was needed
> 20 years ago, it shouldn't be explicitly required nowadays. Current
> versions of autotools already take care of exporting LDFLAGS to the
> Makefile as needed (things are actually getting linked). That's why
> the configure diffs show LDFLAGS still here, but shifted to a diff
> place in the output list. A few dirs stop exporting LDFLAGS, but
> that's because they don't do any linking, only compiling, so it's
> correct.
>
> As for the use of $ldflags instead of the standard $LDFLAGS, I can't
> really explain that at all. Just use the right name so users don't
> have to dig into why their setting isn't respected, and then use a
> non-standard name instead. Adjust the testsuite to match.
LGTM, thanks,
Corinna
next prev parent reply other threads:[~2022-01-21 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 4:51 Mike Frysinger
2022-01-21 11:25 ` Corinna Vinschen [this message]
2023-04-14 21:51 ` Thomas Schwinge
2023-10-16 4:55 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeqYOfGhyfR5D3Cg@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).