From: Mike Frysinger <vapier@gentoo.org>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: newlib@sourceware.org
Subject: Re: [PATCH] newlib: stop clobbering LDFLAGS with non-standard $ldflags
Date: Mon, 16 Oct 2023 10:40:43 +0545 [thread overview]
Message-ID: <ZSzCTyU+CwUDpl7A@vapier> (raw)
In-Reply-To: <87sfd2cetw.fsf@euler.schwinge.homeip.net>
[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]
On 14 Apr 2023 23:51, Thomas Schwinge wrote:
> On 2022-01-20T23:51:52-0500, Mike Frysinger <vapier@gentoo.org> wrote:
> > Adjust the testsuite to match.
>
> > --- a/newlib/testsuite/lib/newlib.exp
> > +++ b/newlib/testsuite/lib/newlib.exp
> > @@ -66,13 +66,13 @@ proc newlib_target_compile { source dest type options } {
> > [target_info needs_status_wrapper] != "0" && \
> > [info exists gluefile] } {
> > lappend options "libs=$gluefile"
> > - lappend options "ldflags=$wrap_flags"
> > + lappend options "LDFLAGS=$wrap_flags"
> > }
> >
> > if [string match $host_triplet $target_triplet] then {
> > if [string match "i686-pc-linux-gnu" $host_triplet] then {
> > lappend options "libs=$objdir/crt0.o -lc -lgcc"
> > - lappend options "ldflags=-nostdlib -L$objdir/.libs [newlib_include_flags]"
> > + lappend options "LDFLAGS=-nostdlib -L$objdir/.libs [newlib_include_flags]"
> > }
> > }
>
> ..., is that really correct? As far as I know, DejaGnu only looks for
> the lower-case 'ldflags' in 'options', as documented in
> '[...]/share/dejagnu/target.exp'. (I just noticed this while looking for
> something else; I don't have any toolchains exercising the code paths
> you've changed.)
tbh, i'm not sure. i tried running the testsuite a few ways, but doesn't
seem to really work :/.
would be nice if these worked out of the box better. maybe with the GNU
sim by default or something.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-10-16 4:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 4:51 Mike Frysinger
2022-01-21 11:25 ` Corinna Vinschen
2023-04-14 21:51 ` Thomas Schwinge
2023-10-16 4:55 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSzCTyU+CwUDpl7A@vapier \
--to=vapier@gentoo.org \
--cc=newlib@sourceware.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).