From: Mike Frysinger <vapier@gentoo.org>
To: newlib@sourceware.org
Subject: Re: [PATCH] newlib: drop redundant AM_MAINTAINER_MODE call
Date: Tue, 1 Mar 2022 20:30:17 -0500 [thread overview]
Message-ID: <Yh7IqW3HC7vDLg9J@vapier> (raw)
In-Reply-To: <Yh4BGuuUg7kbPeuc@calimero.vinschen.de>
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
On 01 Mar 2022 12:18, Corinna Vinschen wrote:
> On Feb 28 23:32, Mike Frysinger wrote:
> > This is already called earlier in this file, so no need to do it again.
> > ---
> > newlib/acinclude.m4 | 2 --
> > newlib/configure | 28 ----------------------------
> > 2 files changed, 30 deletions(-)
> >
> > diff --git a/newlib/acinclude.m4 b/newlib/acinclude.m4
> > index 60fe6ca74852..c50d233b1132 100644
> > --- a/newlib/acinclude.m4
> > +++ b/newlib/acinclude.m4
> > @@ -132,8 +132,6 @@ dnl expanding them multiple times.
> > AC_REQUIRE([AC_PROG_INSTALL])dnl
> > AC_REQUIRE([AC_PROG_AWK])dnl
> >
> > -AM_MAINTAINER_MODE
> > -
> > . [$]{newlib_basedir}/configure.host
> >
> > NEWLIB_CFLAGS=${newlib_cflags}
> > --
> > 2.34.1
>
> Obvious, but the first invocation has unnecessary parens, which
> could go away, too.
yeah, i was trying to keep it minimal, but i can fold that in too
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-03-02 1:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 4:32 Mike Frysinger
2022-03-01 11:18 ` Corinna Vinschen
2022-03-02 1:30 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh7IqW3HC7vDLg9J@vapier \
--to=vapier@gentoo.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).