* [PATCH] newlib: drop redundant AM_MAINTAINER_MODE call
@ 2022-03-01 4:32 Mike Frysinger
2022-03-01 11:18 ` Corinna Vinschen
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2022-03-01 4:32 UTC (permalink / raw)
To: newlib
This is already called earlier in this file, so no need to do it again.
---
newlib/acinclude.m4 | 2 --
newlib/configure | 28 ----------------------------
2 files changed, 30 deletions(-)
diff --git a/newlib/acinclude.m4 b/newlib/acinclude.m4
index 60fe6ca74852..c50d233b1132 100644
--- a/newlib/acinclude.m4
+++ b/newlib/acinclude.m4
@@ -132,8 +132,6 @@ dnl expanding them multiple times.
AC_REQUIRE([AC_PROG_INSTALL])dnl
AC_REQUIRE([AC_PROG_AWK])dnl
-AM_MAINTAINER_MODE
-
. [$]{newlib_basedir}/configure.host
NEWLIB_CFLAGS=${newlib_cflags}
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] newlib: drop redundant AM_MAINTAINER_MODE call
2022-03-01 4:32 [PATCH] newlib: drop redundant AM_MAINTAINER_MODE call Mike Frysinger
@ 2022-03-01 11:18 ` Corinna Vinschen
2022-03-02 1:30 ` Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Corinna Vinschen @ 2022-03-01 11:18 UTC (permalink / raw)
To: newlib
On Feb 28 23:32, Mike Frysinger wrote:
> This is already called earlier in this file, so no need to do it again.
> ---
> newlib/acinclude.m4 | 2 --
> newlib/configure | 28 ----------------------------
> 2 files changed, 30 deletions(-)
>
> diff --git a/newlib/acinclude.m4 b/newlib/acinclude.m4
> index 60fe6ca74852..c50d233b1132 100644
> --- a/newlib/acinclude.m4
> +++ b/newlib/acinclude.m4
> @@ -132,8 +132,6 @@ dnl expanding them multiple times.
> AC_REQUIRE([AC_PROG_INSTALL])dnl
> AC_REQUIRE([AC_PROG_AWK])dnl
>
> -AM_MAINTAINER_MODE
> -
> . [$]{newlib_basedir}/configure.host
>
> NEWLIB_CFLAGS=${newlib_cflags}
> --
> 2.34.1
Obvious, but the first invocation has unnecessary parens, which
could go away, too.
Thx,
Corinna
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] newlib: drop redundant AM_MAINTAINER_MODE call
2022-03-01 11:18 ` Corinna Vinschen
@ 2022-03-02 1:30 ` Mike Frysinger
0 siblings, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2022-03-02 1:30 UTC (permalink / raw)
To: newlib
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
On 01 Mar 2022 12:18, Corinna Vinschen wrote:
> On Feb 28 23:32, Mike Frysinger wrote:
> > This is already called earlier in this file, so no need to do it again.
> > ---
> > newlib/acinclude.m4 | 2 --
> > newlib/configure | 28 ----------------------------
> > 2 files changed, 30 deletions(-)
> >
> > diff --git a/newlib/acinclude.m4 b/newlib/acinclude.m4
> > index 60fe6ca74852..c50d233b1132 100644
> > --- a/newlib/acinclude.m4
> > +++ b/newlib/acinclude.m4
> > @@ -132,8 +132,6 @@ dnl expanding them multiple times.
> > AC_REQUIRE([AC_PROG_INSTALL])dnl
> > AC_REQUIRE([AC_PROG_AWK])dnl
> >
> > -AM_MAINTAINER_MODE
> > -
> > . [$]{newlib_basedir}/configure.host
> >
> > NEWLIB_CFLAGS=${newlib_cflags}
> > --
> > 2.34.1
>
> Obvious, but the first invocation has unnecessary parens, which
> could go away, too.
yeah, i was trying to keep it minimal, but i can fold that in too
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-02 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-01 4:32 [PATCH] newlib: drop redundant AM_MAINTAINER_MODE call Mike Frysinger
2022-03-01 11:18 ` Corinna Vinschen
2022-03-02 1:30 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).