From: Corinna Vinschen <vinschen@redhat.com>
To: Dimitar Dimitrov <dimitar@dinux.eu>
Cc: newlib@sourceware.org
Subject: Re: [PATCH] libgloss: pru: Fix _open syscal arguments
Date: Wed, 27 Apr 2022 11:44:05 +0200 [thread overview]
Message-ID: <YmkQZQTJMQh7tn4u@calimero.vinschen.de> (raw)
In-Reply-To: <20220403185739.2997679-1-dimitar@dinux.eu>
On Apr 3 21:57, Dimitar Dimitrov wrote:
> The _open() C function is declared as having variable arguments in
> newlib, so second and third arguments are passed on stack. Add code to
> move them into registers, since that's where the PRU simulator expects
> them.
>
> Issue was exposed by the GCC test gcc.c-torture/execute/fprintf-2.c,
> which relies on tmpnam implementation to pass correct flags to _open.
>
> Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> ---
> libgloss/pru/syscalls.S | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
Pushed. Sorry for the delay.
Thanks,
Corinna
prev parent reply other threads:[~2022-04-27 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 18:57 Dimitar Dimitrov
2022-04-27 9:44 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmkQZQTJMQh7tn4u@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=dimitar@dinux.eu \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).