From: Corinna Vinschen <vinschen@redhat.com>
To: Dimitar Dimitrov <dimitar@dinux.eu>
Cc: newlib@sourceware.org
Subject: Re: [PATCH] pru: libm: Fix incorrect function name
Date: Mon, 4 Dec 2023 17:38:30 +0100 [thread overview]
Message-ID: <ZW4AhtF-otMUq3bQ@calimero.vinschen.de> (raw)
In-Reply-To: <20231204154242.1391291-1-dimitar@dinux.eu>
On Dec 4 17:42, Dimitar Dimitrov wrote:
> Upstream GCC changed -Wimplicit-function-declaration warning into an
> error. The build break about missing fpclassifyf function prototype
> exposed a bug in the PRU port of libm.
>
> The fix is to use the fpclassify macro for both double and float types.
>
> Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> ---
> newlib/libm/machine/pru/fpclassifyf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/newlib/libm/machine/pru/fpclassifyf.c b/newlib/libm/machine/pru/fpclassifyf.c
> index f4dd201d9..6d82ea777 100644
> --- a/newlib/libm/machine/pru/fpclassifyf.c
> +++ b/newlib/libm/machine/pru/fpclassifyf.c
> @@ -32,5 +32,5 @@
> by TI ABI. */
> int __pruabi_fpclassifyf(float a)
> {
> - return fpclassifyf(a);
> + return fpclassify(a);
> }
> --
> 2.43.0
Pushed.
Thanks,
Corinna
prev parent reply other threads:[~2023-12-04 16:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 15:42 Dimitar Dimitrov
2023-12-04 16:38 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZW4AhtF-otMUq3bQ@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=dimitar@dinux.eu \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).