* [PATCH] pru: libm: Fix incorrect function name
@ 2023-12-04 15:42 Dimitar Dimitrov
2023-12-04 16:38 ` Corinna Vinschen
0 siblings, 1 reply; 2+ messages in thread
From: Dimitar Dimitrov @ 2023-12-04 15:42 UTC (permalink / raw)
To: newlib; +Cc: Dimitar Dimitrov
Upstream GCC changed -Wimplicit-function-declaration warning into an
error. The build break about missing fpclassifyf function prototype
exposed a bug in the PRU port of libm.
The fix is to use the fpclassify macro for both double and float types.
Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
---
newlib/libm/machine/pru/fpclassifyf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newlib/libm/machine/pru/fpclassifyf.c b/newlib/libm/machine/pru/fpclassifyf.c
index f4dd201d9..6d82ea777 100644
--- a/newlib/libm/machine/pru/fpclassifyf.c
+++ b/newlib/libm/machine/pru/fpclassifyf.c
@@ -32,5 +32,5 @@
by TI ABI. */
int __pruabi_fpclassifyf(float a)
{
- return fpclassifyf(a);
+ return fpclassify(a);
}
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pru: libm: Fix incorrect function name
2023-12-04 15:42 [PATCH] pru: libm: Fix incorrect function name Dimitar Dimitrov
@ 2023-12-04 16:38 ` Corinna Vinschen
0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2023-12-04 16:38 UTC (permalink / raw)
To: Dimitar Dimitrov; +Cc: newlib
On Dec 4 17:42, Dimitar Dimitrov wrote:
> Upstream GCC changed -Wimplicit-function-declaration warning into an
> error. The build break about missing fpclassifyf function prototype
> exposed a bug in the PRU port of libm.
>
> The fix is to use the fpclassify macro for both double and float types.
>
> Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
> ---
> newlib/libm/machine/pru/fpclassifyf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/newlib/libm/machine/pru/fpclassifyf.c b/newlib/libm/machine/pru/fpclassifyf.c
> index f4dd201d9..6d82ea777 100644
> --- a/newlib/libm/machine/pru/fpclassifyf.c
> +++ b/newlib/libm/machine/pru/fpclassifyf.c
> @@ -32,5 +32,5 @@
> by TI ABI. */
> int __pruabi_fpclassifyf(float a)
> {
> - return fpclassifyf(a);
> + return fpclassify(a);
> }
> --
> 2.43.0
Pushed.
Thanks,
Corinna
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-04 16:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-04 15:42 [PATCH] pru: libm: Fix incorrect function name Dimitar Dimitrov
2023-12-04 16:38 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).