Re: [PATCH] libc: arm: setjmp.S code cleanup

[Richard Earnshaw <Richard.Earnshaw@foss.arm.com>]

On 14/12/2022 16:46, Victor L. Do Nascimento wrote:
> The code for setjmp and longjmp contains unconditionally-disabled
> legacy FPA code.
> 
> Given the code is not used by any targets, remove the code.
> ---
>   newlib/libc/machine/arm/setjmp.S | 12 ------------
>   1 file changed, 12 deletions(-)
> 
> diff --git a/newlib/libc/machine/arm/setjmp.S b/newlib/libc/machine/arm/setjmp.S
> index 4cf0a8e3f..d814afea8 100644
> --- a/newlib/libc/machine/arm/setjmp.S
> +++ b/newlib/libc/machine/arm/setjmp.S
> @@ -182,12 +182,6 @@ SYM (\name):
>   	vstm		r0, { d8-d15 }
>   #endif
>   
> -#if 0	/* Simulator does not cope with FP instructions yet.  */
> -#ifndef __SOFTFP__
> -	/* Save the floating point registers.  */
> -	sfmea		f4, 4, [a1]
> -#endif
> -#endif
>   	/* When setting up the jump buffer return 0.  */
>   	mov		r0, #0
>   
> @@ -212,12 +206,6 @@ SYM (\name):
>   	vldm		r0, { d8-d15 }
>   #endif
>   
> -#if 0	/* Simulator does not cope with FP instructions yet.  */
> -#ifndef __SOFTFP__
> -	/* Restore floating point registers as well.  */
> -	lfmfd		f4, 4, [a1]
> -#endif
> -#endif
>   	/* Put the return value into the integer result register.
>   	   But if it is zero then return 1 instead.  */
>   	movs		r0, r1

Thanks, pushed.

R.