* [PATCH] libc: arm: setjmp.S code cleanup
@ 2022-12-14 16:46 Victor L. Do Nascimento
2022-12-19 11:23 ` Richard Earnshaw
0 siblings, 1 reply; 2+ messages in thread
From: Victor L. Do Nascimento @ 2022-12-14 16:46 UTC (permalink / raw)
To: newlib; +Cc: Richard.Earnshaw
The code for setjmp and longjmp contains unconditionally-disabled
legacy FPA code.
Given the code is not used by any targets, remove the code.
---
newlib/libc/machine/arm/setjmp.S | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/newlib/libc/machine/arm/setjmp.S b/newlib/libc/machine/arm/setjmp.S
index 4cf0a8e3f..d814afea8 100644
--- a/newlib/libc/machine/arm/setjmp.S
+++ b/newlib/libc/machine/arm/setjmp.S
@@ -182,12 +182,6 @@ SYM (\name):
vstm r0, { d8-d15 }
#endif
-#if 0 /* Simulator does not cope with FP instructions yet. */
-#ifndef __SOFTFP__
- /* Save the floating point registers. */
- sfmea f4, 4, [a1]
-#endif
-#endif
/* When setting up the jump buffer return 0. */
mov r0, #0
@@ -212,12 +206,6 @@ SYM (\name):
vldm r0, { d8-d15 }
#endif
-#if 0 /* Simulator does not cope with FP instructions yet. */
-#ifndef __SOFTFP__
- /* Restore floating point registers as well. */
- lfmfd f4, 4, [a1]
-#endif
-#endif
/* Put the return value into the integer result register.
But if it is zero then return 1 instead. */
movs r0, r1
--
2.36.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libc: arm: setjmp.S code cleanup
2022-12-14 16:46 [PATCH] libc: arm: setjmp.S code cleanup Victor L. Do Nascimento
@ 2022-12-19 11:23 ` Richard Earnshaw
0 siblings, 0 replies; 2+ messages in thread
From: Richard Earnshaw @ 2022-12-19 11:23 UTC (permalink / raw)
To: Victor L. Do Nascimento, newlib
On 14/12/2022 16:46, Victor L. Do Nascimento wrote:
> The code for setjmp and longjmp contains unconditionally-disabled
> legacy FPA code.
>
> Given the code is not used by any targets, remove the code.
> ---
> newlib/libc/machine/arm/setjmp.S | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/newlib/libc/machine/arm/setjmp.S b/newlib/libc/machine/arm/setjmp.S
> index 4cf0a8e3f..d814afea8 100644
> --- a/newlib/libc/machine/arm/setjmp.S
> +++ b/newlib/libc/machine/arm/setjmp.S
> @@ -182,12 +182,6 @@ SYM (\name):
> vstm r0, { d8-d15 }
> #endif
>
> -#if 0 /* Simulator does not cope with FP instructions yet. */
> -#ifndef __SOFTFP__
> - /* Save the floating point registers. */
> - sfmea f4, 4, [a1]
> -#endif
> -#endif
> /* When setting up the jump buffer return 0. */
> mov r0, #0
>
> @@ -212,12 +206,6 @@ SYM (\name):
> vldm r0, { d8-d15 }
> #endif
>
> -#if 0 /* Simulator does not cope with FP instructions yet. */
> -#ifndef __SOFTFP__
> - /* Restore floating point registers as well. */
> - lfmfd f4, 4, [a1]
> -#endif
> -#endif
> /* Put the return value into the integer result register.
> But if it is zero then return 1 instead. */
> movs r0, r1
Thanks, pushed.
R.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-19 11:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-14 16:46 [PATCH] libc: arm: setjmp.S code cleanup Victor L. Do Nascimento
2022-12-19 11:23 ` Richard Earnshaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).