From: "Moore, Catherine" <Catherine_Moore@mentor.com>
To: "newlib@sourceware.org" <newlib@sourceware.org>
Subject: RE: [Patch] Use .syntax unified for arm assembly language routines
Date: Thu, 30 Mar 2017 14:42:00 -0000 [thread overview]
Message-ID: <cfe2c15b53974b43946aa9063fe98e73@svr-orw-mbx-03.mgc.mentorg.com> (raw)
In-Reply-To: <20170330140924.GD10780@calimero.vinschen.de>
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
> -----Original Message-----
> From: Corinna Vinschen [mailto:vinschen@redhat.com]
> Sent: Thursday, March 30, 2017 10:09 AM
> To: Moore, Catherine <Catherine_Moore@mentor.com>
> Cc: newlib@sourceware.org
> Subject: Re: [Patch] Use .syntax unified for arm assembly language
> routines
>
> Hi Catherine,
>
> On Mar 29 23:24, Moore, Catherine wrote:
> > The LLVM integrated assembler doesn't support .syntax divided. I'd
> like to switch to .syntax unified for these two files.
> >
> > For testing, I used GAS to build the files with .syntax divided and
> .syntax unified and compared the object files for differences.
> > They compared the same.
> >
> > OK to commit?
>
> In theory yes, but your patch doesn't apply because it contains spaces
> where the original file has TABs. Can you please regenerate the patch
> with `git format-patch' and attach it to a mail? That works better most
> of the time.
>
>
Sorry about that. Reformatted patch attached.
Thanks,
Catherine
[-- Attachment #2: 0001-Use-.syntax-unified-instead-of-.syntax-divided.patch --]
[-- Type: application/octet-stream, Size: 1236 bytes --]
From d8f7d4657b137a8a485ecdbf5f52bc4b61f3ef31 Mon Sep 17 00:00:00 2001
From: Catherine Moore <clm@codesourcery.com>
Date: Thu, 30 Mar 2017 07:26:23 -0700
Subject: [PATCH] Use .syntax unified instead of .syntax divided.
---
newlib/libc/machine/arm/aeabi_memmove-arm.S | 2 +-
newlib/libc/machine/arm/aeabi_memset-arm.S | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/newlib/libc/machine/arm/aeabi_memmove-arm.S b/newlib/libc/machine/arm/aeabi_memmove-arm.S
index e6e9639..541444d 100644
--- a/newlib/libc/machine/arm/aeabi_memmove-arm.S
+++ b/newlib/libc/machine/arm/aeabi_memmove-arm.S
@@ -27,7 +27,7 @@
*/
.arm
- .syntax divided
+ .syntax unified
.global __aeabi_memmove
.type __aeabi_memmove, %function
ASM_ALIAS __aeabi_memmove4 __aeabi_memmove
diff --git a/newlib/libc/machine/arm/aeabi_memset-arm.S b/newlib/libc/machine/arm/aeabi_memset-arm.S
index 0f91e3a..1c7bec5 100644
--- a/newlib/libc/machine/arm/aeabi_memset-arm.S
+++ b/newlib/libc/machine/arm/aeabi_memset-arm.S
@@ -27,7 +27,7 @@
*/
.arm
- .syntax divided
+ .syntax unified
.global __aeabi_memset
.type __aeabi_memset, %function
ASM_ALIAS __aeabi_memset4 __aeabi_memset
--
2.8.1
next prev parent reply other threads:[~2017-03-30 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 23:24 Moore, Catherine
2017-03-30 14:09 ` Corinna Vinschen
2017-03-30 14:42 ` Moore, Catherine [this message]
2017-03-30 15:19 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfe2c15b53974b43946aa9063fe98e73@svr-orw-mbx-03.mgc.mentorg.com \
--to=catherine_moore@mentor.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).