From: "Moore, Catherine" <Catherine_Moore@mentor.com>
To: "newlib@sourceware.org" <newlib@sourceware.org>
Cc: "Moore, Catherine" <Catherine_Moore@mentor.com>
Subject: [Patch] Use .syntax unified for arm assembly language routines
Date: Wed, 29 Mar 2017 23:24:00 -0000 [thread overview]
Message-ID: <fa9833969d5441e691bb6317d4363e04@svr-orw-mbx-03.mgc.mentorg.com> (raw)
The LLVM integrated assembler doesn't support .syntax divided. I'd like to switch to .syntax unified for these two files.
For testing, I used GAS to build the files with .syntax divided and .syntax unified and compared the object files for differences.
They compared the same.
OK to commit?
Thanks,
Catherine
diff --git a/newlib/libc/machine/arm/aeabi_memmove-arm.S b/newlib/libc/machine/arm/aeabi_memmove-arm.S
index e6e9639..541444d 100644
--- a/newlib/libc/machine/arm/aeabi_memmove-arm.S
+++ b/newlib/libc/machine/arm/aeabi_memmove-arm.S
@@ -27,7 +27,7 @@
*/
.arm
- .syntax divided
+ .syntax unified
.global __aeabi_memmove
.type __aeabi_memmove, %function
ASM_ALIAS __aeabi_memmove4 __aeabi_memmove
diff --git a/newlib/libc/machine/arm/aeabi_memset-arm.S b/newlib/libc/machine/arm/aeabi_memset-arm.S
index 0f91e3a..1c7bec5 100644
--- a/newlib/libc/machine/arm/aeabi_memset-arm.S
+++ b/newlib/libc/machine/arm/aeabi_memset-arm.S
@@ -27,7 +27,7 @@
*/
.arm
- .syntax divided
+ .syntax unified
.global __aeabi_memset
.type __aeabi_memset, %function
ASM_ALIAS __aeabi_memset4 __aeabi_memset
next reply other threads:[~2017-03-29 23:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 23:24 Moore, Catherine [this message]
2017-03-30 14:09 ` Corinna Vinschen
2017-03-30 14:42 ` Moore, Catherine
2017-03-30 15:19 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa9833969d5441e691bb6317d4363e04@svr-orw-mbx-03.mgc.mentorg.com \
--to=catherine_moore@mentor.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).