public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Corinna Vinschen <vinschen@redhat.com>
To: "Moore, Catherine" <Catherine_Moore@mentor.com>
Cc: "newlib@sourceware.org" <newlib@sourceware.org>
Subject: Re: [Patch] Use .syntax unified for arm assembly language routines
Date: Thu, 30 Mar 2017 15:19:00 -0000	[thread overview]
Message-ID: <20170330151907.GE10780@calimero.vinschen.de> (raw)
In-Reply-To: <cfe2c15b53974b43946aa9063fe98e73@svr-orw-mbx-03.mgc.mentorg.com>

[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]

On Mar 30 14:42, Moore, Catherine wrote:
> 
> 
> > -----Original Message-----
> > From: Corinna Vinschen [mailto:vinschen@redhat.com]
> > Sent: Thursday, March 30, 2017 10:09 AM
> > To: Moore, Catherine <Catherine_Moore@mentor.com>
> > Cc: newlib@sourceware.org
> > Subject: Re: [Patch] Use .syntax unified for arm assembly language
> > routines
> > 
> > Hi Catherine,
> > 
> > On Mar 29 23:24, Moore, Catherine wrote:
> > > The LLVM integrated assembler doesn't support .syntax divided.  I'd
> > like to switch to .syntax unified for these two files.
> > >
> > > For testing, I used GAS to build the files with .syntax divided and
> > .syntax unified and compared the object files for differences.
> > > They compared the same.
> > >
> > > OK to commit?
> > 
> > In theory yes, but your patch doesn't apply because it contains spaces
> > where the original file has TABs.  Can you please regenerate the patch
> > with `git format-patch' and attach it to a mail?  That works better most
> > of the time.
> > 
> > 
> 
> Sorry about that.  Reformatted patch attached.
> Thanks,
> Catherine

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2017-03-30 15:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-29 23:24 Moore, Catherine
2017-03-30 14:09 ` Corinna Vinschen
2017-03-30 14:42   ` Moore, Catherine
2017-03-30 15:19     ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170330151907.GE10780@calimero.vinschen.de \
    --to=vinschen@redhat.com \
    --cc=Catherine_Moore@mentor.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).