* [PATCH] fix some Arm FP routines not checking if floating point is enabled
@ 2021-04-21 12:48 Ties Stuij
2021-04-21 15:19 ` Richard Earnshaw
0 siblings, 1 reply; 4+ messages in thread
From: Ties Stuij @ 2021-04-21 12:48 UTC (permalink / raw)
To: newlib
A lot of the Arm FP routines check for the availability of floating point by way
of `(__ARM_FP & 0x4)`. However some do not. This patch remedies this.
---
newlib/libm/machine/arm/sf_ceil.c | 2 +-
newlib/libm/machine/arm/sf_floor.c | 2 +-
newlib/libm/machine/arm/sf_nearbyint.c | 2 +-
newlib/libm/machine/arm/sf_rint.c | 2 +-
newlib/libm/machine/arm/sf_round.c | 2 +-
newlib/libm/machine/arm/sf_trunc.c | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/newlib/libm/machine/arm/sf_ceil.c b/newlib/libm/machine/arm/sf_ceil.c
index b6efbff0b..44fdf834a 100644
--- a/newlib/libm/machine/arm/sf_ceil.c
+++ b/newlib/libm/machine/arm/sf_ceil.c
@@ -24,7 +24,7 @@
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
-#if __ARM_ARCH >= 8 && !defined (__SOFTFP__)
+#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__)
#include <math.h>
float
diff --git a/newlib/libm/machine/arm/sf_floor.c b/newlib/libm/machine/arm/sf_floor.c
index 7bc95808c..44c38c42c 100644
--- a/newlib/libm/machine/arm/sf_floor.c
+++ b/newlib/libm/machine/arm/sf_floor.c
@@ -24,7 +24,7 @@
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
-#if __ARM_ARCH >= 8 && !defined (__SOFTFP__)
+#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__)
#include <math.h>
float
diff --git a/newlib/libm/machine/arm/sf_nearbyint.c b/newlib/libm/machine/arm/sf_nearbyint.c
index c70d84442..126673e97 100644
--- a/newlib/libm/machine/arm/sf_nearbyint.c
+++ b/newlib/libm/machine/arm/sf_nearbyint.c
@@ -24,7 +24,7 @@
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
-#if __ARM_ARCH >= 8 && !defined (__SOFTFP__)
+#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__)
#include <math.h>
float
diff --git a/newlib/libm/machine/arm/sf_rint.c b/newlib/libm/machine/arm/sf_rint.c
index d9c383a7e..5def21009 100644
--- a/newlib/libm/machine/arm/sf_rint.c
+++ b/newlib/libm/machine/arm/sf_rint.c
@@ -24,7 +24,7 @@
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
-#if __ARM_ARCH >= 8 && !defined (__SOFTFP__)
+#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__)
#include <math.h>
float
diff --git a/newlib/libm/machine/arm/sf_round.c b/newlib/libm/machine/arm/sf_round.c
index 232fc0848..88c53ba13 100644
--- a/newlib/libm/machine/arm/sf_round.c
+++ b/newlib/libm/machine/arm/sf_round.c
@@ -24,7 +24,7 @@
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
-#if __ARM_ARCH >= 8 && !defined (__SOFTFP__)
+#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__)
#include <math.h>
float
diff --git a/newlib/libm/machine/arm/sf_trunc.c b/newlib/libm/machine/arm/sf_trunc.c
index 64e4aeb9a..c08fa6fed 100644
--- a/newlib/libm/machine/arm/sf_trunc.c
+++ b/newlib/libm/machine/arm/sf_trunc.c
@@ -24,7 +24,7 @@
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
-#if __ARM_ARCH >= 8 && !defined (__SOFTFP__)
+#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__)
#include <math.h>
float
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix some Arm FP routines not checking if floating point is enabled
2021-04-21 12:48 [PATCH] fix some Arm FP routines not checking if floating point is enabled Ties Stuij
@ 2021-04-21 15:19 ` Richard Earnshaw
0 siblings, 0 replies; 4+ messages in thread
From: Richard Earnshaw @ 2021-04-21 15:19 UTC (permalink / raw)
To: Ties Stuij, newlib
Pushed.
R.
On 21/04/2021 13:48, Ties Stuij wrote:
> A lot of the Arm FP routines check for the availability of floating point by way
> of `(__ARM_FP & 0x4)`. However some do not. This patch remedies this.
> ---
> newlib/libm/machine/arm/sf_ceil.c | 2 +-
> newlib/libm/machine/arm/sf_floor.c | 2 +-
> newlib/libm/machine/arm/sf_nearbyint.c | 2 +-
> newlib/libm/machine/arm/sf_rint.c | 2 +-
> newlib/libm/machine/arm/sf_round.c | 2 +-
> newlib/libm/machine/arm/sf_trunc.c | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/newlib/libm/machine/arm/sf_ceil.c b/newlib/libm/machine/arm/sf_ceil.c
> index b6efbff0b..44fdf834a 100644
> --- a/newlib/libm/machine/arm/sf_ceil.c
> +++ b/newlib/libm/machine/arm/sf_ceil.c
> @@ -24,7 +24,7 @@
> NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
> SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
>
> -#if __ARM_ARCH >= 8 && !defined (__SOFTFP__)
> +#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__)
> #include <math.h>
>
> float
> diff --git a/newlib/libm/machine/arm/sf_floor.c b/newlib/libm/machine/arm/sf_floor.c
> index 7bc95808c..44c38c42c 100644
> --- a/newlib/libm/machine/arm/sf_floor.c
> +++ b/newlib/libm/machine/arm/sf_floor.c
> @@ -24,7 +24,7 @@
> NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
> SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
>
> -#if __ARM_ARCH >= 8 && !defined (__SOFTFP__)
> +#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__)
> #include <math.h>
>
> float
> diff --git a/newlib/libm/machine/arm/sf_nearbyint.c b/newlib/libm/machine/arm/sf_nearbyint.c
> index c70d84442..126673e97 100644
> --- a/newlib/libm/machine/arm/sf_nearbyint.c
> +++ b/newlib/libm/machine/arm/sf_nearbyint.c
> @@ -24,7 +24,7 @@
> NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
> SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
>
> -#if __ARM_ARCH >= 8 && !defined (__SOFTFP__)
> +#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__)
> #include <math.h>
>
> float
> diff --git a/newlib/libm/machine/arm/sf_rint.c b/newlib/libm/machine/arm/sf_rint.c
> index d9c383a7e..5def21009 100644
> --- a/newlib/libm/machine/arm/sf_rint.c
> +++ b/newlib/libm/machine/arm/sf_rint.c
> @@ -24,7 +24,7 @@
> NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
> SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
>
> -#if __ARM_ARCH >= 8 && !defined (__SOFTFP__)
> +#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__)
> #include <math.h>
>
> float
> diff --git a/newlib/libm/machine/arm/sf_round.c b/newlib/libm/machine/arm/sf_round.c
> index 232fc0848..88c53ba13 100644
> --- a/newlib/libm/machine/arm/sf_round.c
> +++ b/newlib/libm/machine/arm/sf_round.c
> @@ -24,7 +24,7 @@
> NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
> SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
>
> -#if __ARM_ARCH >= 8 && !defined (__SOFTFP__)
> +#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__)
> #include <math.h>
>
> float
> diff --git a/newlib/libm/machine/arm/sf_trunc.c b/newlib/libm/machine/arm/sf_trunc.c
> index 64e4aeb9a..c08fa6fed 100644
> --- a/newlib/libm/machine/arm/sf_trunc.c
> +++ b/newlib/libm/machine/arm/sf_trunc.c
> @@ -24,7 +24,7 @@
> NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
> SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
>
> -#if __ARM_ARCH >= 8 && !defined (__SOFTFP__)
> +#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__)
> #include <math.h>
>
> float
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fix some Arm FP routines not checking if floating point is enabled
2021-04-21 12:56 Ties Stuij
@ 2021-04-21 13:08 ` Joel Sherrill
0 siblings, 0 replies; 4+ messages in thread
From: Joel Sherrill @ 2021-04-21 13:08 UTC (permalink / raw)
To: Ties Stuij; +Cc: Newlib
If the patch hasn't been merged, just clean it up and send a V2 of it.
On Wed, Apr 21, 2021, 7:57 AM Ties Stuij <Ties.Stuij@arm.com> wrote:
> Hi there,
>
> I sent two patches with the above subject to the list. The first patch
> accidentally included extra changes that are unrelated to this particular
> issue, so it can be dropped. As can this email.
>
> Sorry for the noise.
>
> Best,
> /Ties Stuij
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] fix some Arm FP routines not checking if floating point is enabled
@ 2021-04-21 12:56 Ties Stuij
2021-04-21 13:08 ` Joel Sherrill
0 siblings, 1 reply; 4+ messages in thread
From: Ties Stuij @ 2021-04-21 12:56 UTC (permalink / raw)
To: newlib
Hi there,
I sent two patches with the above subject to the list. The first patch accidentally included extra changes that are unrelated to this particular issue, so it can be dropped. As can this email.
Sorry for the noise.
Best,
/Ties Stuij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-21 15:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 12:48 [PATCH] fix some Arm FP routines not checking if floating point is enabled Ties Stuij
2021-04-21 15:19 ` Richard Earnshaw
2021-04-21 12:56 Ties Stuij
2021-04-21 13:08 ` Joel Sherrill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).