From: Paul Zimmermann <Paul.Zimmermann@inria.fr>
To: Jeff Johnston <jjohnstn@redhat.com>
Cc: newlib@sourceware.org
Subject: Re: regression in tgamma?
Date: Thu, 17 Dec 2020 08:29:06 +0100 [thread overview]
Message-ID: <mwim90yjp9.fsf@tomate.loria.fr> (raw)
In-Reply-To: <CAOox84srOEu0YS0WPv8CfVzfKFqQ3M3Z=RXtbQXomwj4qyjxWQ@mail.gmail.com> (message from Jeff Johnston on Wed, 16 Dec 2020 15:31:47 -0500)
Hi Jeff,
> From: Jeff Johnston <jjohnstn@redhat.com>
> Date: Wed, 16 Dec 2020 15:31:47 -0500
>
> Hi Paul,
>
> I believe I found the problem.
>
> The __ieee754_tgamma functions are not declared in fdlibm.h so the calls in
> tgamma and tgammaf are using
> default parms and getting things wrong. My test calling __ieee754_tgamma
> directly only worked after I added
> a declaration to __ieee754_tgamma locally.
>
> I have pushed a change to master. Please try it out.
>
> -- Jeff J.
with revision 865cd30 I now get:
zimmerma@tomate:/tmp/newlib-cygwin$ ./a.out
x=-0x0p+0 y=inf
x=-0x1.53f198fe3b278p+7 y=0x1.fd6d312572d9cp-1015
The double value is ok, however the float result should be -inf.
This should have been fixed by Keith Packard in commit 4641693.
Paul
next prev parent reply other threads:[~2020-12-17 7:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 13:48 Paul Zimmermann
2020-12-16 20:31 ` Jeff Johnston
2020-12-17 7:29 ` Paul Zimmermann [this message]
2020-12-17 16:13 ` Keith Packard
2020-12-17 18:27 ` Jeff Johnston
2020-12-17 19:16 ` Keith Packard
2020-12-17 21:28 ` Jeff Johnston
2020-12-18 6:36 ` Paul Zimmermann
2020-12-18 8:42 ` Corinna Vinschen
2020-12-18 8:54 ` Paul Zimmermann
2020-12-18 9:07 ` Corinna Vinschen
2020-12-18 17:42 ` Jeff Johnston
2020-12-18 8:37 ` Paul Zimmermann
-- strict thread matches above, loose matches on Subject: below --
2020-12-15 13:35 Paul Zimmermann
2020-12-15 17:11 ` Jeff Johnston
2020-12-16 6:36 ` Paul Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mwim90yjp9.fsf@tomate.loria.fr \
--to=paul.zimmermann@inria.fr \
--cc=jjohnstn@redhat.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).