Re: regression in tgamma?

[Jeff Johnston <jjohnstn@redhat.com>]

Thanks Keith,

I have modified er_lgamma.c, erf_lgamma.c, w_tgamma.c, wf_tgamma.c based on
code changes in picolibc.
I did not add the new ___ieee754_ sub-functions and instead modified the
existing code assuming that the function
was called with *signgam = 0.  We can always do a merge from picolibc in
the future.

With the new code, the test runs as expected.

Paul, please confirm before tomorrow.

Thanks,

-- Jeff J.

On Thu, Dec 17, 2020 at 2:17 PM Keith Packard <keithp@keithp.com> wrote:

> Jeff Johnston <jjohnstn@redhat.com> writes:
>
> > I am also seeing inf instead of -inf for both tgamma and tgammaf in my
> > testing.
>
> Yeah, looks like there are quite a few fixes in picolibc that I haven't
> had time to send over to newlib.
>
> I've also fixed a bunch of exception problems when compiling with clang,
> which is happy to evaluate expressions known at compile time, even
> though that doesn't generate exceptions at runtime. (things like 'return
> one/zero;')
>
> I've also generated tests for return values, exceptions and errnos for
> the math functions to make sure they match the relevant specs and also
> match glibc (mostly as a way to check the tests).
>
> Anyone is welcome to pull those fixes out of picolibc and get them into
> newlib; I probably won't have time for a while.
>
> --
> -keith
>