From: Jeff Johnston <jjohnstn@redhat.com>
To: Newlib <newlib@sourceware.org>
Cc: Corinna Vinschen <vinschen@redhat.com>
Subject: Re: regression in tgamma?
Date: Fri, 18 Dec 2020 12:42:23 -0500 [thread overview]
Message-ID: <CAOox84ssikf0=sMtM8vTzJWoaT1qfROOyVQ6YaUWbi3zCDerTw@mail.gmail.com> (raw)
In-Reply-To: <20201218090726.GO4560@calimero.vinschen.de>
Thanks Paul, Corinna. I was testing locally in my directory and had a
work-around for errno already in place.
I will make the snapshot later this afternoon.
-- Jeff J.
On Fri, Dec 18, 2020 at 4:07 AM Corinna Vinschen via Newlib <
newlib@sourceware.org> wrote:
> On Dec 18 09:54, Paul Zimmermann wrote:
> > Dear Corinna,
> >
> > sorry, here is the patch generated by "git format-patch".
>
> Thanks, I pushed the patch.
>
>
> Corinna
>
>
> >
> > Paul
> >
> > >From bb94a62d68012fc38a0b6b14cedb806ff86b5c29 Mon Sep 17 00:00:00 2001
> > From: Paul Zimmermann <Paul.Zimmermann@inria.fr>
> > Date: Fri, 18 Dec 2020 09:52:40 +0100
> > Subject: [PATCH] fixes to make compilation succeeds
> >
> > ---
> > newlib/libm/math/w_tgamma.c | 1 +
> > newlib/libm/math/wf_tgamma.c | 2 +-
> > 2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/newlib/libm/math/w_tgamma.c b/newlib/libm/math/w_tgamma.c
> > index 0f90dd4c6..52d5d71d3 100644
> > --- a/newlib/libm/math/w_tgamma.c
> > +++ b/newlib/libm/math/w_tgamma.c
> > @@ -16,6 +16,7 @@
> > */
> >
> > #include "fdlibm.h"
> > +#include <errno.h>
> >
> > #ifndef _DOUBLE_IS_32BITS
> >
> > diff --git a/newlib/libm/math/wf_tgamma.c b/newlib/libm/math/wf_tgamma.c
> > index 80aacf757..504cb4c29 100644
> > --- a/newlib/libm/math/wf_tgamma.c
> > +++ b/newlib/libm/math/wf_tgamma.c
> > @@ -15,6 +15,7 @@
> >
> > #include "math.h"
> > #include "fdlibm.h"
> > +#include <errno.h>
> >
> > #ifdef __STDC__
> > float tgammaf(float x)
> > @@ -34,7 +35,6 @@
> > errno = EDOM;
> > else if (finite(x))
> > errno = ERANGE;
> > - }
> > return y;
> > #endif
> > }
> > --
> > 2.29.2
>
>
next prev parent reply other threads:[~2020-12-18 17:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 13:48 Paul Zimmermann
2020-12-16 20:31 ` Jeff Johnston
2020-12-17 7:29 ` Paul Zimmermann
2020-12-17 16:13 ` Keith Packard
2020-12-17 18:27 ` Jeff Johnston
2020-12-17 19:16 ` Keith Packard
2020-12-17 21:28 ` Jeff Johnston
2020-12-18 6:36 ` Paul Zimmermann
2020-12-18 8:42 ` Corinna Vinschen
2020-12-18 8:54 ` Paul Zimmermann
2020-12-18 9:07 ` Corinna Vinschen
2020-12-18 17:42 ` Jeff Johnston [this message]
2020-12-18 8:37 ` Paul Zimmermann
-- strict thread matches above, loose matches on Subject: below --
2020-12-15 13:35 Paul Zimmermann
2020-12-15 17:11 ` Jeff Johnston
2020-12-16 6:36 ` Paul Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOox84ssikf0=sMtM8vTzJWoaT1qfROOyVQ6YaUWbi3zCDerTw@mail.gmail.com' \
--to=jjohnstn@redhat.com \
--cc=newlib@sourceware.org \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).