Re: src/winsup/cygwin common.din syscalls.cc inclu ...

Re: src/winsup/cygwin common.din syscalls.cc inclu ...

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]

It looks like things recently changed on sourceware so that the links in
these emails no longer work.

On 10/08/2014 03:03 PM, corinna@cygwin.com wrote:
> CVSROOT:	/cvs/src
> Module name:	src
> Changes by:	corinna@sourceware.org	2014-10-08 21:03:41
> 
> Modified files:
> 	winsup/cygwin  : common.din syscalls.cc 
> 	winsup/cygwin/include/cygwin: version.h 
> 
> Log message:
> 	* common.din (ffsl): Export.
> 	(ffsll): Export.
> 	* syscalls.cc (ffs): Implement using GCC intrinsic.
> 	(ffsl): Ditto.
> 	(ffsll): Ditto.
> 	* include/cygwin/version.h (CYGWIN_VERSION_API_MINOR): Bump.
> 
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/src/winsup/cygwin/common.din.diff?cvsroot=src&r1=1.9&r2=1.10

This resolves to:
 https://sourceware.org/viewvc/src?cvsroot=src&r1=1.9&r2=1.10 and gives
a 404, while a little bit of experimenting shows that:
 https://sourceware.org/viewvc/src/winsup/cygwin/common.din.diff?cvsroot=src&r1=1.9&r2=1.10
works just fine.

> http://sourceware.org/cgi-bin/cvsweb.cgi/src/winsup/cygwin/syscalls.cc.diff?cvsroot=src&r1=1.667&r2=1.668
> http://sourceware.org/cgi-bin/cvsweb.cgi/src/winsup/cygwin/include/cygwin/version.h.diff?cvsroot=src&r1=1.406&r2=1.407
> 
> 
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]

Re: src/winsup/cygwin common.din syscalls.cc inclu ...

[Frank Ch. Eigler]

Hi -

> It looks like things recently changed on sourceware so that the links in
> these emails no longer work.
> [...]
> > Patches:
> > http://sourceware.org/cgi-bin/cvsweb.cgi/src/winsup/cygwin/common.din.diff?cvsroot=src&r1=1.9&r2=1.10

Sorry about that; a while ago when a yet another security
vulnerability in cvsweb.cgi came by, it seemed harmless to switch it
out for (redirect to) the other cvs-viewer platform already installed
on sourceware.  I did not know about this usage, so the redirection
part wasn't sophisticated enough.

I'll tweak the forwarding regex widget to make those URLs work, if
possible.  It'd be nice to change the cvs hooks (?) to generate direct
viewvc URLs too sometime.

- FChE

Re: src/winsup/cygwin common.din syscalls.cc inclu ...

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 968 bytes --]

Hi,

On Oct  9 06:09, Frank Ch. Eigler wrote:
> Hi -
> 
> > It looks like things recently changed on sourceware so that the links in
> > these emails no longer work.
> > [...]
> > > Patches:
> > > http://sourceware.org/cgi-bin/cvsweb.cgi/src/winsup/cygwin/common.din.diff?cvsroot=src&r1=1.9&r2=1.10
> 
> Sorry about that; a while ago when a yet another security
> vulnerability in cvsweb.cgi came by, it seemed harmless to switch it
> out for (redirect to) the other cvs-viewer platform already installed
> on sourceware.  I did not know about this usage, so the redirection
> part wasn't sophisticated enough.
> 
> I'll tweak the forwarding regex widget to make those URLs work, if
> possible.

Seems to work fine now, thanks!

> It'd be nice to change the cvs hooks (?) to generate direct
> viewvc URLs too sometime.

How can we do that?  Where is this configured?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: src/winsup/cygwin common.din syscalls.cc inclu ...

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1132 bytes --]

On Oct  9 13:50, Corinna Vinschen wrote:
> Hi,
> 
> On Oct  9 06:09, Frank Ch. Eigler wrote:
> > Hi -
> > 
> > > It looks like things recently changed on sourceware so that the links in
> > > these emails no longer work.
> > > [...]
> > > > Patches:
> > > > http://sourceware.org/cgi-bin/cvsweb.cgi/src/winsup/cygwin/common.din.diff?cvsroot=src&r1=1.9&r2=1.10
> > 
> > Sorry about that; a while ago when a yet another security
> > vulnerability in cvsweb.cgi came by, it seemed harmless to switch it
> > out for (redirect to) the other cvs-viewer platform already installed
> > on sourceware.  I did not know about this usage, so the redirection
> > part wasn't sophisticated enough.
> > 
> > I'll tweak the forwarding regex widget to make those URLs work, if
> > possible.
> 
> Seems to work fine now, thanks!
> 
> > It'd be nice to change the cvs hooks (?) to generate direct
> > viewvc URLs too sometime.
> 
> How can we do that?  Where is this configured?

Is that something we can do at all without overseers intervention?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: src/winsup/cygwin common.din syscalls.cc inclu ...

[Frank Ch. Eigler]

Hi -


On Mon, Oct 13, 2014 at 02:54:39PM +0200, Corinna Vinschen wrote:
> [...]
> > > It'd be nice to change the cvs hooks (?) to generate direct
> > > viewvc URLs too sometime.
> > 
> > How can we do that?  Where is this configured?
> 
> Is that something we can do at all without overseers intervention?

On brief searching, it seems like a matter for overseers:
  /sourceware/infra/bin/log_accum

- FChE

Re: src/winsup/cygwin common.din syscalls.cc inclu ...

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]

Hi,

On Oct  9 13:50, Corinna Vinschen wrote:
> On Oct  9 06:09, Frank Ch. Eigler wrote:
> > Hi -
> > 
> > > It looks like things recently changed on sourceware so that the links in
> > > these emails no longer work.
> > > [...]
> > > > Patches:
> > > > http://sourceware.org/cgi-bin/cvsweb.cgi/src/winsup/cygwin/common.din.diff?cvsroot=src&r1=1.9&r2=1.10
> > 
> > Sorry about that; a while ago when a yet another security
> > vulnerability in cvsweb.cgi came by, it seemed harmless to switch it
> > out for (redirect to) the other cvs-viewer platform already installed
> > on sourceware.  I did not know about this usage, so the redirection
> > part wasn't sophisticated enough.
> > 
> > I'll tweak the forwarding regex widget to make those URLs work, if
> > possible.
> 
> Seems to work fine now, thanks!

The CVS mails from the cygwin-apps repo are affected as well, apparently.
For instance, this link given in a mail on the cygwin-apps-cvs mailing
list:

  http://sourceware.org/cgi-bin/cvsweb.cgi/login/login.1.diff?cvsroot=cygwin-apps&r1=1.1.1.1&r2=1.2

now redirects to

  https://sourceware.org/viewvc/src/

Can this be fixed, please?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

Re: src/winsup/cygwin common.din syscalls.cc inclu ...

[Frank Ch. Eigler]

Hi -

> For instance, this link given in a mail on the cygwin-apps-cvs mailing list:
>   http://sourceware.org/cgi-bin/cvsweb.cgi/login/login.1.diff?cvsroot=cygwin-apps&r1=1.1.1.1&r2=1.2
> Can this be fixed, please?

Done.

- FChE

Re: src/winsup/cygwin common.din syscalls.cc inclu ...

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

On Oct 17 11:54, Frank Ch. Eigler wrote:
> Hi -
> 
> > For instance, this link given in a mail on the cygwin-apps-cvs mailing list:
> >   http://sourceware.org/cgi-bin/cvsweb.cgi/login/login.1.diff?cvsroot=cygwin-apps&r1=1.1.1.1&r2=1.2
> > Can this be fixed, please?
> 
> Done.

Thanks!


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]