Fwd: https patchwork URLs (was "Re: Patchwork account confirmation")

Fwd: https patchwork URLs (was "Re: Patchwork account confirmation")

[Yann Droneaud]

Hi,


I've registered against patchwork today and noticed

1) patchwork.sourceware.org seems to be available through both http and 
https, and http was use by default on first use;

2) link in email uses http (see below)


Le 02/06/2022 à 11:13, Patchwork a écrit :

> Hi,
>
> This email is to confirm your account on the patchwork patch-tracking
> system. You can activate your account by visiting the url:
>
> http://patchwork.sourceware.org/confirm/<redacted>/
>
> If you didn't request a user account on patchwork, then you can ignore
> this mail.
>
> Happy patchworking.


It would be great if TLS/SSL would always be prefered:

1) http://patchwork.sourceware.org/ redirect to 
https://patchwork.sourceware.org/

2) email uses https://patchwork.sourceware.org/



Regards.

-- 

Yann Droneaud

OPTEYA

Re: Fwd: https patchwork URLs (was "Re: Patchwork account confirmation")

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

Hi Yann,

Thanks for noticing patchwork still uses http instead of https in some
places.

On Tue, Jun 07, 2022 at 03:38:32PM +0200, Yann Droneaud via Overseers wrote:
> It would be great if TLS/SSL would always be prefered:
> 
> 1) http://patchwork.sourceware.org/ redirect to
> https://patchwork.sourceware.org/

It should now always redirect to https for any 

> 2) email uses https://patchwork.sourceware.org/

All mail templates were updated to use https.

Please do report if you find any more plain http instead of https
links.

Thanks,

Mark

[-- Attachment #2: https-template-mails.patch --]
[-- Type: text/x-diff, Size: 3758 bytes --]

commit d3debb1568df0ce6728e62b1b1f380a8023c0d94
Author: Mark Wielaard <mark@klomp.org>
Date:   Sat Jun 11 13:02:46 2022 +0000

    Replace http:// with https:// in templates/patchwork/mails

diff --git a/patchwork/templates/patchwork/mails/activation.txt b/patchwork/templates/patchwork/mails/activation.txt
index 34e2fce..16cc30c 100644
--- a/patchwork/templates/patchwork/mails/activation.txt
+++ b/patchwork/templates/patchwork/mails/activation.txt
@@ -3,7 +3,7 @@ Hi,
 This email is to confirm your account on the patchwork patch-tracking
 system. You can activate your account by visiting the url:
 
- http://{{site.domain}}{% url 'confirm' key=confirmation.key %}
+ https://{{site.domain}}{% url 'confirm' key=confirmation.key %}
 
 If you didn't request a user account on patchwork, then you can ignore
 this mail.
diff --git a/patchwork/templates/patchwork/mails/optin-request.txt b/patchwork/templates/patchwork/mails/optin-request.txt
index bd40e67..fe8fd51 100644
--- a/patchwork/templates/patchwork/mails/optin-request.txt
+++ b/patchwork/templates/patchwork/mails/optin-request.txt
@@ -5,7 +5,7 @@ email from the Patchwork system at {{site.domain}}.
 
 To complete the opt-in process, visit:
 
- http://{{site.domain}}{% url 'confirm' key=confirmation.key %}
+ https://{{site.domain}}{% url 'confirm' key=confirmation.key %}
 
 If you didn't request this opt-in, you don't need to do anything.
 
diff --git a/patchwork/templates/patchwork/mails/optout-request.txt b/patchwork/templates/patchwork/mails/optout-request.txt
index b1732fd..a740590 100644
--- a/patchwork/templates/patchwork/mails/optout-request.txt
+++ b/patchwork/templates/patchwork/mails/optout-request.txt
@@ -5,7 +5,7 @@ from the Patchwork system at {{site.domain}}.
 
 To complete the opt-out process, visit:
 
- http://{{site.domain}}{% url 'confirm' key=confirmation.key %}
+ https://{{site.domain}}{% url 'confirm' key=confirmation.key %}
 
 If you didn't request this opt-out, you don't need to do anything.
 
diff --git a/patchwork/templates/patchwork/mails/patch-change-notification.txt b/patchwork/templates/patchwork/mails/patch-change-notification.txt
index 7d04cff..0396a86 100644
--- a/patchwork/templates/patchwork/mails/patch-change-notification.txt
+++ b/patchwork/templates/patchwork/mails/patch-change-notification.txt
@@ -3,7 +3,7 @@ Hello,
 The following patch{{notifications|length|pluralize:"es"}} (submitted by you) {{notifications|length|pluralize:"has,have"}} been updated in Patchwork:
 {% for notification in notifications %}
  * {{notification.patch.project.linkname}}: {{notification.patch.name|safe}}
-     - http://{{site.domain}}{{notification.patch.get_absolute_url}}
+     - https://{{site.domain}}{{notification.patch.get_absolute_url}}
      - for: {{notification.patch.project.name}}
     was: {{notification.orig_state}}
     now: {{notification.patch.state}}
@@ -17,4 +17,4 @@ Happy patchworking.
 This is an automated mail sent by the Patchwork system at
 {{site.domain}}. To stop receiving these notifications, edit
 your mail settings at:
-  http://{{site.domain}}{% url 'mail-settings' %}
+  https://{{site.domain}}{% url 'mail-settings' %}
diff --git a/patchwork/templates/patchwork/mails/user-link.txt b/patchwork/templates/patchwork/mails/user-link.txt
index d0a3c97..e9f5019 100644
--- a/patchwork/templates/patchwork/mails/user-link.txt
+++ b/patchwork/templates/patchwork/mails/user-link.txt
@@ -7,6 +7,6 @@ This email is to confirm that you own the email address:
 So that you can add it to your Patchwork profile. You can confirm this
 email address by visiting the url:
 
- http://{{site.domain}}{% url 'confirm' key=confirmation.key %}
+ https://{{site.domain}}{% url 'confirm' key=confirmation.key %}
 
 Happy patchworking.

Re: Fwd: https patchwork URLs (was "Re: Patchwork account confirmation")

[Yann Droneaud]

Hi,

Le 11/06/2022 à 15:15, Mark Wielaard a écrit :
> Thanks for noticing patchwork still uses http instead of https in some
> places.
>
> On Tue, Jun 07, 2022 at 03:38:32PM +0200, Yann Droneaud via Overseers wrote:
>> It would be great if TLS/SSL would always be prefered:
>>
>> 1) http://patchwork.sourceware.org/ redirect to
>> https://patchwork.sourceware.org/
> It should now always redirect to https for any
>
>> 2) email uses https://patchwork.sourceware.org/
> All mail templates were updated to use https.
>
> Please do report if you find any more plain http instead of https
> links.


Great, thanks a lot !


Regards.

-- 

Yann Droneaud

OPTEYA