From: Jakub Jelinek <jakub@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: prelink@sourceware.org
Subject: Re: More helpful error message during path walk
Date: Tue, 04 Dec 2007 16:24:00 -0000 [thread overview]
Message-ID: <20071204162410.GC16835@devserv.devel.redhat.com> (raw)
In-Reply-To: <20071204161229.GA7758@caradoc.them.org>
On Tue, Dec 04, 2007 at 11:12:29AM -0500, Daniel Jacobowitz wrote:
> I don't remember if I've sent this before, but I couldn't find a
> record of it. I was working on a filesystem where nftw64 failed
> (maybe permissions? bad symlink? I don't remember, sorry), and
> nothing eventually led to an error message. So prelink failed to
> prelink some files I expected it to, but didn't say why not. The
> obvious patch made it much clearer what was happening.
I'd worry about ENOENT errors, because prelink.conf generally contains
a bunch of dirs that may not be present and that should be silent.
But in that case already stat64 at the beginning of gather_object
should fail with ENOENT and when implicit this should silently return,
so I guess the patch is ok. Please commit it.
> 2007-04-30 Daniel Jacobowitz <dan@codesourcery.com>
>
> * gather.c (gather_object): Print an error if nftw64 fails.
Jakub
next prev parent reply other threads:[~2007-12-04 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 16:12 Daniel Jacobowitz
2007-12-04 16:24 ` Jakub Jelinek [this message]
2007-12-04 16:43 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071204162410.GC16835@devserv.devel.redhat.com \
--to=jakub@redhat.com \
--cc=drow@false.org \
--cc=prelink@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).