public inbox for pthreads-win32@sourceware.org
 help / color / mirror / Atom feed
* PThread Win32 problem with pthread_cleanup_push / pop
@ 2004-10-30 18:43 Dany Joly
  2004-10-31  0:15 ` Ross Johnson
  0 siblings, 1 reply; 2+ messages in thread
From: Dany Joly @ 2004-10-30 18:43 UTC (permalink / raw)
  To: pthreads-win32

Hi,

I am unable to compile a VC++project (with  .NET 2003 and 6.0) that uses the 
pthread_cleanup_push and pthread_cleanup_pop macro defined in pthread.h 
without replacing the following code at line 686 of pthread.h:

Previous ( '}' seems to be missing):

#ifdef __CLEANUP_C

        /*
         * C implementation of PThreads cancel cleanup
         */

#define pthread_cleanup_push( _rout, _arg ) \
        { \
            ptw32_cleanup_t     _cleanup; \
            \
            ptw32_push_cleanup( &_cleanup, (ptw32_cleanup_callback_t) 
(_rout), (_arg) ); \

#define pthread_cleanup_pop( _execute ) \
            (void) ptw32_pop_cleanup( _execute ); \
        }

#else /* __CLEANUP_C */


New (only added '}' at the end of the macro):

#ifdef __CLEANUP_C

        /*
         * C implementation of PThreads cancel cleanup
         */

#define pthread_cleanup_push( _rout, _arg ) \
        { \
            ptw32_cleanup_t     _cleanup; \
            \
            ptw32_push_cleanup( &_cleanup, (ptw32_cleanup_callback_t) 
(_rout), (_arg) ); \
        }
#define pthread_cleanup_pop( _execute ) \
		{ \
            (void) ptw32_pop_cleanup( _execute ); \
		}

#else /* __CLEANUP_C */


I compared the header with older versions from 2002 and this has been 
unchanged for 2 years. Is it really a bug or something I don't understand?


Thank you,
Dany


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PThread Win32 problem with pthread_cleanup_push / pop
  2004-10-30 18:43 PThread Win32 problem with pthread_cleanup_push / pop Dany Joly
@ 2004-10-31  0:15 ` Ross Johnson
  0 siblings, 0 replies; 2+ messages in thread
From: Ross Johnson @ 2004-10-31  0:15 UTC (permalink / raw)
  To: Dany Joly, pthreads-win32

No no. These macros are supposed to form a pair, so that together they 
form the start and end of the same block.

Ross

Dany Joly wrote:

> Hi,
>
> I am unable to compile a VC++project (with  .NET 2003 and 6.0) that 
> uses the pthread_cleanup_push and pthread_cleanup_pop macro defined in 
> pthread.h without replacing the following code at line 686 of pthread.h:
>
> Previous ( '}' seems to be missing):
>
> #ifdef __CLEANUP_C
>
>        /*
>         * C implementation of PThreads cancel cleanup
>         */
>
> #define pthread_cleanup_push( _rout, _arg ) \
>        { \
>            ptw32_cleanup_t     _cleanup; \
>            \
>            ptw32_push_cleanup( &_cleanup, (ptw32_cleanup_callback_t) 
> (_rout), (_arg) ); \
>
> #define pthread_cleanup_pop( _execute ) \
>            (void) ptw32_pop_cleanup( _execute ); \
>        }
>
> #else /* __CLEANUP_C */
>
>
> New (only added '}' at the end of the macro):
>
> #ifdef __CLEANUP_C
>
>        /*
>         * C implementation of PThreads cancel cleanup
>         */
>
> #define pthread_cleanup_push( _rout, _arg ) \
>        { \
>            ptw32_cleanup_t     _cleanup; \
>            \
>            ptw32_push_cleanup( &_cleanup, (ptw32_cleanup_callback_t) 
> (_rout), (_arg) ); \
>        }
> #define pthread_cleanup_pop( _execute ) \
>         { \
>            (void) ptw32_pop_cleanup( _execute ); \
>         }
>
> #else /* __CLEANUP_C */
>
>
> I compared the header with older versions from 2002 and this has been 
> unchanged for 2 years. Is it really a bug or something I don't 
> understand?
>
>
> Thank you,
> Dany
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-10-31  0:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-30 18:43 PThread Win32 problem with pthread_cleanup_push / pop Dany Joly
2004-10-31  0:15 ` Ross Johnson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).