From: "Frank Ch. Eigler" <fche@redhat.com>
To: Dave Brolley <brolley@redhat.com>
Cc: sid@sources.redhat.com
Subject: Re: [patch] Add Logging Support for SID Components
Date: Sun, 01 Jun 2003 14:32:00 -0000 [thread overview]
Message-ID: <20030601143239.GA31953@redhat.com> (raw)
In-Reply-To: <3ED7CCCB.4070004@redhat.com>
Hi -
> The attached patch adds logging support for sid components in 3 stages:
> [...]
Looks fine - good use of virtual inheritance. A few minor things
I might have done differently:
- make a new component type for named file I/O, instead of
changing sid-io-stdio; after all, stdio is bidirectional,
meant to be interactive
- think of some other way to call stdout than "*"
- make logging output buffering dependent on an attribute (set as the last
gasp of configuration) instead of pin-connectedness
- having a C++ flavour API (instead of printf()) for the logging function
- FChE
next prev parent reply other threads:[~2003-06-01 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-30 21:27 Dave Brolley
2003-05-30 21:44 ` Dave Brolley
2003-06-01 14:32 ` Frank Ch. Eigler [this message]
2003-06-01 23:52 ` Ben Elliston
2003-06-02 0:01 ` Dave Brolley
2003-06-09 14:15 ` Dave Brolley
2003-06-09 14:50 ` Frank Ch. Eigler
2003-06-09 17:03 ` Dave Brolley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030601143239.GA31953@redhat.com \
--to=fche@redhat.com \
--cc=brolley@redhat.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).