From: "Frank Ch. Eigler" <fche@redhat.com>
To: Dave Brolley <brolley@redhat.com>
Cc: sid@sources.redhat.com
Subject: Re: [patch] Add Logging Support for SID Components
Date: Mon, 09 Jun 2003 14:50:00 -0000 [thread overview]
Message-ID: <20030609144958.GB23478@redhat.com> (raw)
In-Reply-To: <3EE49705.8000802@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 639 bytes --]
Hi -
> This new patch replaces the previous one and addresses some of the
> concerns below....
Addressing my suggestions was not intended as a prerequisite for
committing your previous version.
The new version seems to have at least one actual problem though:
the way that the buffer array is managed. Its allocation/deallocation
strategy should be consistent (probably "new char[]" and "delete[] char")
regardless of the availability of the various *sprintf variants. It should
probably not even be in #if/#endif markers. The new code appears to be
able to hit free() even though malloc() was never called.
- FChE
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2003-06-09 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-30 21:27 Dave Brolley
2003-05-30 21:44 ` Dave Brolley
2003-06-01 14:32 ` Frank Ch. Eigler
2003-06-01 23:52 ` Ben Elliston
2003-06-02 0:01 ` Dave Brolley
2003-06-09 14:15 ` Dave Brolley
2003-06-09 14:50 ` Frank Ch. Eigler [this message]
2003-06-09 17:03 ` Dave Brolley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030609144958.GB23478@redhat.com \
--to=fche@redhat.com \
--cc=brolley@redhat.com \
--cc=sid@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).