[patch] logger::delete_saved_messages

[patch] logger::delete_saved_messages

[Dave Brolley]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

This corrects the clearing of saved_messages and saved_levels. The 
previous code was just plain incorrect and caused memory access problems 
on some platforms.

Dave


[-- Attachment #2: logger.ChangeLog --]
[-- Type: text/plain, Size: 111 bytes --]

2003-12-17  Dave Brolley  <brolley@redhat.com>

	* sidmiscutil.h (delete_saved_messages): Use 'clear' method.


[-- Attachment #3: logger.patch.txt --]
[-- Type: text/plain, Size: 1177 bytes --]

Index: sid/include/sidmiscutil.h
===================================================================
RCS file: /cvs/src/src/sid/include/sidmiscutil.h,v
retrieving revision 1.7
retrieving revision 1.8
diff -c -p -r1.7 -r1.8
*** sid/include/sidmiscutil.h	21 Oct 2003 21:38:24 -0000	1.7
--- sid/include/sidmiscutil.h	17 Dec 2003 19:51:02 -0000	1.8
***************
*** 1,6 ****
  // sidmiscutil.h - Useful utility classes.  -*- C++ -*-
  
! // Copyright (C) 1999-2002 Red Hat.
  // This file is part of SID and is licensed under the GPL.
  // See the file COPYING.SID for conditions for redistribution.
  
--- 1,6 ----
  // sidmiscutil.h - Useful utility classes.  -*- C++ -*-
  
! // Copyright (C) 1999-2003 Red Hat.
  // This file is part of SID and is licensed under the GPL.
  // See the file COPYING.SID for conditions for redistribution.
  
*************** namespace sidutil
*** 526,532 ****
    public:
      void delete_saved_messages ()
      {
!       saved_messages.erase (saved_messages.end ());
      }
    };
  
--- 526,533 ----
    public:
      void delete_saved_messages ()
      {
!       saved_messages.clear ();
!       saved_levels.clear ();
      }
    };
  

Re: [patch] logger::delete_saved_messages

[Dave Brolley]

I forgot to mention that this is already committed.

Dave Brolley wrote:

> This corrects the clearing of saved_messages and saved_levels. The 
> previous code was just plain incorrect and caused memory access 
> problems on some platforms.
>