RE: Patch to fix init_disassemble_info linking

RE: Patch to fix init_disassemble_info linking

[Robert Cragie]

It looks like there is an error in the Makefile, which has come from
Makefile.in, which is in turn generated by 'automake' from Makefile.am - I
feel it might be something to do with incompatibilities in 'automake'. The
error is probably this line, as there is no '\' at the end:

> OPCODES_COMPILE_FLAGS =
-DHAVE_CONFIG_H       -I../../../opcodes      -I../../../bfd

If you have 'automake' on your cygwin system (if not, I would suggest
getting it from Redhat), I would patch 'Makefile.am' only, then run
automake.

Alternatively you could try this simpler patch for 'Makefile.in' which sorts
the problem out:

Index: sid/component/cgen-cpu/Makefile.in
===================================================================
RCS file: /cvs/src/src/sid/component/cgen-cpu/Makefile.in,v
retrieving revision 1.9
diff -r1.9 Makefile.in
115,116c115,116
< libcgencpu_la_LIBADD = @cpu_libs@ $(INTLLIBS) $(LIBIBERTY) cgen-asm.lo
cgen-dis.lo cgen-opc.lo dis-buf.lo
< libcgencpu_la_DEPENDENCIES = @cpu_libs@ cgen-asm.lo cgen-dis.lo
cgen-opc.lo
dis-buf.lo
---
> libcgencpu_la_LIBADD = @cpu_libs@ $(INTLLIBS) $(LIBIBERTY) cgen-asm.lo
cgen-dis.lo cgen-opc.lo dis-buf.lo dis-init.lo
> libcgencpu_la_DEPENDENCIES = @cpu_libs@ cgen-asm.lo cgen-dis.lo
cgen-opc.lo
dis-buf.lo dis-init.lo
580a573,575
>       /bin/sh ./libtool --mode=compile $(CC) $(OPCODES_COMPILE_FLAGS)
$(CFLAGS)
-c $<
>
> dis-init.lo: ../../../opcodes/dis-init.c

You then need to do:

make distclean
../src/configure ...etc.
make all 2>&1 | tee make.out

Please supply inline text output of the error, not JPEGs and especially not
bitmaps (as they are large). If you look at the 'make all' line above, it
shows you how to do this. The result of the build will then be in
'make.out' - you can cut and paste the error bit.

Robert Cragie, Design Engineer
_______________________________________________________________
Jennic Ltd, Furnival Street, Sheffield, S1 4QT,  UK
http://www.jennic.com  Tel: +44 (0) 114 281 2655
_______________________________________________________________

> -----Original Message-----
> From: Ashutosh [mailto:ashutoshvyas@tataelxsi.co.in]
> Sent: 10 May 2004 09:42
> To: 'Robert Cragie'
> Subject: RE: Patch to fix init_disassemble_info linking
>
>
> Dear Robert ,
> Thanks for your solution.I had followed the step which you had
> given in your
> mail. I patched the Makefile.in and Makefile.asm.
> But I am obtaining new error. Please have a look. It is in the JPEG
format,
> attached with this mail.
> Regards,
> Ashutosh

(from JPEG):
Makefile:119: *** missing separator.  Stop.

Re: Patch to fix init_disassemble_info linking

[Frank Ch. Eigler]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

Hi -

rcc wrote:

> It looks like there is an error in the Makefile, which has come from
> Makefile.in [...]

Hm, the committed version already works for me.  Interesting.
Maybe there is a DOS end-of-line issue with your checkout?

- FChE

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

RE: Patch to fix init_disassemble_info linking

[Robert Cragie]

Yes, perhaps it is a result of Ashutosh pasting the patch from an email.

Ashutosh: There are two things you can do:

1) (Recommended) Get the latest CVS version of SID as Frank has committed
the patch which will fix the problem. Perhaps there will be a snapshot soon?

2) Paste the patch from the post I sent earlier into a file then run:

perl -pe 's/\r\n/\n/' -i <file patch is in>

to remove all carriage returns from it. Then apply the patch as usual and
rebuild as per the earlier post (don't forget the --disable-static as well
on the configure command line).

Robert Cragie, Design Engineer
_______________________________________________________________
Jennic Ltd, Furnival Street, Sheffield, S1 4QT,  UK
http://www.jennic.com  Tel: +44 (0) 114 281 2655
_______________________________________________________________

> -----Original Message-----
> From: Frank Ch. Eigler [mailto:fche@redhat.com]
> Sent: 10 May 2004 18:14
> To: Robert Cragie
> Cc: ashutoshvyas@tataelxsi.co.in; SID
> Subject: Re: Patch to fix init_disassemble_info linking
>
>
> Hi -
>
> rcc wrote:
>
> > It looks like there is an error in the Makefile, which has come from
> > Makefile.in [...]
>
> Hm, the committed version already works for me.  Interesting.
> Maybe there is a DOS end-of-line issue with your checkout?
>
> - FChE
>

RE: Patch to fix init_disassemble_info linking

[Ashutosh]

Dear Robert,
Thnaks for valuable information, I was able to build the SID with e-cos. But
I am facing right now a uncertain problem. As after building the SID it
create a file (like arm-elf-sid) in the d:/gnutools/bin folder but it is not
in the .exe or application format. As a result when I try to invoke SID it
gives an command-not found error.
Can u please explain me, where I am going wrong.
Thanks once again for your all help.
Regards,
Ashutosh Vyas

-----Original Message-----
From: sid-owner@sources.redhat.com
[mailto:sid-owner@sources.redhat.com]On Behalf Of Robert Cragie
Sent: Tuesday, May 11, 2004 2:53 PM
To: Frank Ch. Eigler
Cc: ashutoshvyas@tataelxsi.co.in; SID
Subject: RE: Patch to fix init_disassemble_info linking


Yes, perhaps it is a result of Ashutosh pasting the patch from an email.

Ashutosh: There are two things you can do:

1) (Recommended) Get the latest CVS version of SID as Frank has committed
the patch which will fix the problem. Perhaps there will be a snapshot soon?

2) Paste the patch from the post I sent earlier into a file then run:

perl -pe 's/\r\n/\n/' -i <file patch is in>

to remove all carriage returns from it. Then apply the patch as usual and
rebuild as per the earlier post (don't forget the --disable-static as well
on the configure command line).

Robert Cragie, Design Engineer
_______________________________________________________________
Jennic Ltd, Furnival Street, Sheffield, S1 4QT,  UK
http://www.jennic.com  Tel: +44 (0) 114 281 2655
_______________________________________________________________

> -----Original Message-----
> From: Frank Ch. Eigler [mailto:fche@redhat.com]
> Sent: 10 May 2004 18:14
> To: Robert Cragie
> Cc: ashutoshvyas@tataelxsi.co.in; SID
> Subject: Re: Patch to fix init_disassemble_info linking
>
>
> Hi -
>
> rcc wrote:
>
> > It looks like there is an error in the Makefile, which has come from
> > Makefile.in [...]
>
> Hm, the committed version already works for me.  Interesting.
> Maybe there is a DOS end-of-line issue with your checkout?
>
> - FChE
>

RE: Patch to fix init_disassemble_info linking

[Robert Cragie]

arm-elf-sid is a shell script, not an executable. Try :

bash arm-elf-sid

or just simply:

./arm-elf-sid

from a bash shell, or make sure it is in your path.

Robert Cragie, Design Engineer
_______________________________________________________________
Jennic Ltd, Furnival Street, Sheffield, S1 4QT,  UK
http://www.jennic.com  Tel: +44 (0) 114 281 2655
_______________________________________________________________

> -----Original Message-----
> From: Ashutosh [mailto:ashutoshvyas@tataelxsi.co.in]
> Sent: 14 May 2004 08:48
> To: 'Robert Cragie'; 'Frank Ch. Eigler'
> Cc: 'SID'
> Subject: RE: Patch to fix init_disassemble_info linking
>
>
> Dear Robert,
> Thnaks for valuable information, I was able to build the SID with
> e-cos. But
> I am facing right now a uncertain problem. As after building the SID it
> create a file (like arm-elf-sid) in the d:/gnutools/bin folder
> but it is not
> in the .exe or application format. As a result when I try to invoke SID it
> gives an command-not found error.
> Can u please explain me, where I am going wrong.
> Thanks once again for your all help.
> Regards,
> Ashutosh Vyas
>
> -----Original Message-----
> From: sid-owner@sources.redhat.com
> [mailto:sid-owner@sources.redhat.com]On Behalf Of Robert Cragie
> Sent: Tuesday, May 11, 2004 2:53 PM
> To: Frank Ch. Eigler
> Cc: ashutoshvyas@tataelxsi.co.in; SID
> Subject: RE: Patch to fix init_disassemble_info linking
>
>
> Yes, perhaps it is a result of Ashutosh pasting the patch from an email.
>
> Ashutosh: There are two things you can do:
>
> 1) (Recommended) Get the latest CVS version of SID as Frank has committed
> the patch which will fix the problem. Perhaps there will be a
> snapshot soon?
>
> 2) Paste the patch from the post I sent earlier into a file then run:
>
> perl -pe 's/\r\n/\n/' -i <file patch is in>
>
> to remove all carriage returns from it. Then apply the patch as usual and
> rebuild as per the earlier post (don't forget the --disable-static as well
> on the configure command line).
>
> Robert Cragie, Design Engineer
> _______________________________________________________________
> Jennic Ltd, Furnival Street, Sheffield, S1 4QT,  UK
> http://www.jennic.com  Tel: +44 (0) 114 281 2655
> _______________________________________________________________
>
> > -----Original Message-----
> > From: Frank Ch. Eigler [mailto:fche@redhat.com]
> > Sent: 10 May 2004 18:14
> > To: Robert Cragie
> > Cc: ashutoshvyas@tataelxsi.co.in; SID
> > Subject: Re: Patch to fix init_disassemble_info linking
> >
> >
> > Hi -
> >
> > rcc wrote:
> >
> > > It looks like there is an error in the Makefile, which has come from
> > > Makefile.in [...]
> >
> > Hm, the committed version already works for me.  Interesting.
> > Maybe there is a DOS end-of-line issue with your checkout?
> >
> > - FChE
> >
>
>

Patch to fix init_disassemble_info linking

[Robert Cragie]

This patch, along the lines of what Frank was suggesting, seems to fix the 
build - not tried running it though. Note it looks like I am using a 
newer version of automake.

? cvs.diff
Index: sid/component/cgen-cpu/Makefile.am
===================================================================
RCS file: /cvs/src/src/sid/component/cgen-cpu/Makefile.am,v
retrieving revision 1.8
diff -r1.8 Makefile.am
25,26c25,26
< libcgencpu_la_LIBADD = @cpu_libs@ $(INTLLIBS) $(LIBIBERTY) cgen-asm.lo 
cgen-dis.lo cgen-opc.lo dis-buf.lo
< libcgencpu_la_DEPENDENCIES = @cpu_libs@ cgen-asm.lo cgen-dis.lo cgen-opc.lo 
dis-buf.lo
---
> libcgencpu_la_LIBADD = @cpu_libs@ $(INTLLIBS) $(LIBIBERTY) cgen-asm.lo 
cgen-dis.lo cgen-opc.lo dis-buf.lo dis-init.lo
> libcgencpu_la_DEPENDENCIES = @cpu_libs@ cgen-asm.lo cgen-dis.lo cgen-opc.lo 
dis-buf.lo dis-init.lo
47a48,50
>       /bin/sh ./libtool --mode=compile $(CC) $(OPCODES_COMPILE_FLAGS) 
$(CFLAGS) 
-c $<
> 
> dis-init.lo: ../../../opcodes/dis-init.c
Index: sid/component/cgen-cpu/Makefile.in
===================================================================
RCS file: /cvs/src/src/sid/component/cgen-cpu/Makefile.in,v
retrieving revision 1.9
diff -r1.9 Makefile.in
1c1
< # Makefile.in generated automatically by automake 1.4-p5 from Makefile.am
---
> # Makefile.in generated automatically by automake 1.4-p6 from Makefile.am
115,116c115,116
< libcgencpu_la_LIBADD = @cpu_libs@ $(INTLLIBS) $(LIBIBERTY) cgen-asm.lo 
cgen-dis.lo cgen-opc.lo dis-buf.lo
< libcgencpu_la_DEPENDENCIES = @cpu_libs@ cgen-asm.lo cgen-dis.lo cgen-opc.lo 
dis-buf.lo
---
> libcgencpu_la_LIBADD = @cpu_libs@ $(INTLLIBS) $(LIBIBERTY) cgen-asm.lo 
cgen-dis.lo cgen-opc.lo dis-buf.lo dis-init.lo
> libcgencpu_la_DEPENDENCIES = @cpu_libs@ cgen-asm.lo cgen-dis.lo cgen-opc.lo 
dis-buf.lo dis-init.lo
118,126c118
< OPCODES_COMPILE_FLAGS = -DHAVE_CONFIG_H \
<       -I../../../opcodes \
<       -I../../../bfd \
<       -I../../../intl \
<       -I$(srcdir)/../../../opcodes \
<       -I$(srcdir)/../../../include \
<       -I$(srcdir)/../../../bfd     \
<       -I$(srcdir)/../../../intl    \
<       -D_GNU_SOURCE 
---
> OPCODES_COMPILE_FLAGS = 
-DHAVE_CONFIG_H       -I../../../opcodes      -I../../../bfd 
        -I../../../intl         -I$(srcdir)/../../../opcodes    -I$(srcdir)/../../../include 
        -I$(srcdir)/../../../bfd        -I$(srcdir)/../../../intl       -D_GNU_SOURCE 
152c144
< aclocal.m4 config.in configure configure.in
---
> acinclude.m4 aclocal.m4 config.in configure configure.in
173c165
< $(ACLOCAL_M4): @MAINTAINER_MODE_TRUE@ configure.in 
---
> $(ACLOCAL_M4): @MAINTAINER_MODE_TRUE@ configure.in  acinclude.m4
580a573,575
>       /bin/sh ./libtool --mode=compile $(CC) $(OPCODES_COMPILE_FLAGS) 
$(CFLAGS) 
-c $<
> 
> dis-init.lo: ../../../opcodes/dis-init.c

Re: Patch to fix init_disassemble_info linking

[Frank Ch. Eigler]

Hi -

On Sat, May 08, 2004 at 11:56:25AM +0100, Robert Cragie wrote:
> This patch, along the lines of what Frank was suggesting, seems to fix the 
> build - not tried running it though. [...]

Thanks much for the patch; I am committing a slight
variant of it in your name.

- FChE