From: Sami Liedes <sami.liedes@iki.fi>
To: systemtap@sourceware.org
Subject: Re: automated way to find functions that we might want to blacklist
Date: Thu, 19 Jan 2012 13:10:00 -0000 [thread overview]
Message-ID: <20120119131003.GC26534@sli.dy.fi> (raw)
In-Reply-To: <4F15D792.2050408@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
On Tue, Jan 17, 2012 at 02:18:26PM -0600, David Smith wrote:
> A couple of these don't make any sense to me:
>
> > * hash_64
> > * hash_ptr
>
> There is nothing that those 2 functions do that can crash the kernel.
> Those functions (should be) always inlined. I'd guess the problem isn't
> those two functions, but the function that is calling them.
Is there a way to blacklist a single place where one of these is
inlined? I don't think blacklisting the offending function where these
are inlined would prevent the crash with 'probe
kernel.function("hash_64") {}'. Or would it?
After some testing with 3.2.0 and .call, only these two functions have
caused crashes so far (in KVM):
* inat_get_opcode_attribute
* native_set_debugreg
The first of these is already included in the blacklist of systemtap
git HEAD, but the second one is new.
Sami
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-19 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 23:33 Timo Juhani Lindfors
2011-12-24 14:27 ` Sami Liedes
2012-01-15 21:46 ` Sami Liedes
2012-01-15 22:13 ` Sami Liedes
2012-01-17 20:18 ` David Smith
2012-01-17 21:55 ` Sami Liedes
2012-01-19 13:10 ` Sami Liedes [this message]
2012-01-19 16:42 ` Josh Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119131003.GC26534@sli.dy.fi \
--to=sami.liedes@iki.fi \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).