From: David Smith <dsmith@redhat.com>
To: Prerna Saxena <prerna@linux.vnet.ibm.com>
Cc: systemtap@sourceware.org
Subject: Re: Tapset for probing IRQs, workqueues, etc
Date: Mon, 26 Oct 2009 20:12:00 -0000 [thread overview]
Message-ID: <4AE602B6.7080809@redhat.com> (raw)
In-Reply-To: <4AE1E981.9050002@linux.vnet.ibm.com>
On 10/23/2009 12:36 PM, Prerna Saxena wrote:
> Hi,
>
> Attached is a tracepoint based tapset for probing IRQ handlers,
> softirqs, and workqueue operations.
> Of these, softirqs and irq handler based probes cannot have kprobe
> equivalents, 'cos of the kprobe blacklist. And the position of
> tracepoints for workqueues makes it difficult to define a kprobe
> fallback for most of these probes.
>
> Looking fwd to feedback to improve it..
I took a short look at your tapset. In general, it looks fine.
I do have one question. You added a function called '_irqflags_str' to
aux_syscalls.stp, but I couldn't find a caller of that new function in
your tapset. It looks like you might have meant to call it for the
'flags' variables in irq_handler.entry and irq_handler.exit.
It would be really nice if your new tapset automatically generated its
own documentation. I don't think it would be much additional work over
the comments you have now. See the "Documentation" section of the
"Tapset Developer's Guide"
<http://sources.redhat.com/git/?p=systemtap.git;a=blob_plain;f=tapset/DEVGUIDE>
for more details.
It would also be great if your tapset had a simple testcase that made
sure everything compiled.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)
next prev parent reply other threads:[~2009-10-26 20:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 17:36 Prerna Saxena
2009-10-26 20:12 ` David Smith [this message]
2009-10-29 15:55 ` Prerna Saxena
2009-10-29 23:14 ` Josh Stone
2009-11-09 6:13 ` Prerna Saxena
2009-11-13 12:56 ` Mark Wielaard
2009-11-16 6:02 ` Prerna Saxena
2009-11-16 9:38 ` Mark Wielaard
2009-10-26 21:15 ` Josh Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE602B6.7080809@redhat.com \
--to=dsmith@redhat.com \
--cc=prerna@linux.vnet.ibm.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).