From: Prerna Saxena <prerna@linux.vnet.ibm.com>
To: Josh Stone <jistone@redhat.com>
Cc: systemtap@sourceware.org, David Smith <dsmith@redhat.com>
Subject: Re: Tapset for probing IRQs, workqueues, etc
Date: Mon, 09 Nov 2009 06:13:00 -0000 [thread overview]
Message-ID: <4AF7B2FA.5010506@linux.vnet.ibm.com> (raw)
In-Reply-To: <4AEA21C6.8000303@redhat.com>
On 10/30/2009 04:44 AM, Josh Stone wrote:
> On 10/29/2009 08:55 AM, Prerna Saxena wrote:
>> Hi ,
>> Posting a new version of the IRQ tapset.
>> I have not included the flags string on purpose for this probe point,
>> cos I think that one might need to look up the flags in specific
>> debugging scenarios only. It would not be required in most commonly used
>> cases, such as the attached example. However, I have documented the
>> function both inline in the tapset documentation and also in the man
>> pages, so that a script developer wanting to display a formatted string
>> can call the function when needed.
>
> It wouldn't hurt to have the tapset provide it as something like
> flags_str. That makes it more obvious for the user, and our optimizer
> should remove it automatically if it's not used.
>
Thanks!
Fixed in commit a476086d1ef0448c86e466f5955f78d282b473fd for new IRQ tapset.
--
Prerna Saxena
Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India
next prev parent reply other threads:[~2009-11-09 6:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 17:36 Prerna Saxena
2009-10-26 20:12 ` David Smith
2009-10-29 15:55 ` Prerna Saxena
2009-10-29 23:14 ` Josh Stone
2009-11-09 6:13 ` Prerna Saxena [this message]
2009-11-13 12:56 ` Mark Wielaard
2009-11-16 6:02 ` Prerna Saxena
2009-11-16 9:38 ` Mark Wielaard
2009-10-26 21:15 ` Josh Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF7B2FA.5010506@linux.vnet.ibm.com \
--to=prerna@linux.vnet.ibm.com \
--cc=dsmith@redhat.com \
--cc=jistone@redhat.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).