From: Mark Wielaard <mjw@redhat.com>
To: Prerna Saxena <prerna@linux.vnet.ibm.com>
Cc: Josh Stone <jistone@redhat.com>,
systemtap@sourceware.org, David Smith <dsmith@redhat.com>
Subject: Re: Tapset for probing IRQs, workqueues, etc
Date: Mon, 16 Nov 2009 09:38:00 -0000 [thread overview]
Message-ID: <1258364221.4763.6.camel@springer.wildebeest.org> (raw)
In-Reply-To: <4B00EA9E.7080403@linux.vnet.ibm.com>
On Mon, 2009-11-16 at 11:31 +0530, Prerna Saxena wrote:
> Thanks for pointing it out..
No problem. You added a testcase, it failed. So easy to detect :)
> I guess my patch hadnt applied cleanly !
> I've added this via commit dc5a95301448c26bc016ebc618a8038e531d85f0
Thanks. I added one small workaround for kernel < 2.6.32 (which isn't
actually released yet) which don't have IRQF_ONESHOT. With that
everything passes also on my systems.
Cheers,
Mark
From 7b76473cbad92366721defee51d93396cb101134 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mjw@redhat.com>
Date: Mon, 16 Nov 2009 10:33:20 +0100
Subject: [PATCH] Define IRQF_ONESHOT for older kernels.
IRQF_ONESHOT was only introduced in 2.6.32. It doesn't hurt defining it
if it isn't already there. It will just never show up on older kernels.
* tapset/aux_syscalls.stp: Define IRQF_ONESHOT if not already defined.
---
tapset/aux_syscalls.stp | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/tapset/aux_syscalls.stp b/tapset/aux_syscalls.stp
index d544472..5435d3a 100644
--- a/tapset/aux_syscalls.stp
+++ b/tapset/aux_syscalls.stp
@@ -1900,6 +1900,9 @@ function _struct_sigaction32_u:string(uaddr:long)
%{
#include <linux/interrupt.h>
+#ifndef IRQF_ONESHOT
+#define IRQF_ONESHOT 0x00002000
+#endif
static const _stp_val_array const _stp_irq_list[] = {
V(IRQF_DISABLED),
V(IRQF_SAMPLE_RANDOM),
--
1.6.2.5
next prev parent reply other threads:[~2009-11-16 9:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 17:36 Prerna Saxena
2009-10-26 20:12 ` David Smith
2009-10-29 15:55 ` Prerna Saxena
2009-10-29 23:14 ` Josh Stone
2009-11-09 6:13 ` Prerna Saxena
2009-11-13 12:56 ` Mark Wielaard
2009-11-16 6:02 ` Prerna Saxena
2009-11-16 9:38 ` Mark Wielaard [this message]
2009-10-26 21:15 ` Josh Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258364221.4763.6.camel@springer.wildebeest.org \
--to=mjw@redhat.com \
--cc=dsmith@redhat.com \
--cc=jistone@redhat.com \
--cc=prerna@linux.vnet.ibm.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).