From: Masami Hiramatsu <mhiramat@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Roland McGrath <roland@redhat.com>,
lkml <linux-kernel@vger.kernel.org>,
systemtap <systemtap@sources.redhat.com>,
DLE <dle-develop@lists.sourceforge.net>
Subject: Re: [PATCH -tip 3/3] Add get_signal tracepoint
Date: Mon, 16 Nov 2009 21:52:00 -0000 [thread overview]
Message-ID: <4B01C95B.1070302@redhat.com> (raw)
In-Reply-To: <20091114001020.GB24738@elte.hu>
Ingo Molnar wrote:
>> Especially if you call this "get" rather than "deliver", there is
>> another place that should invoke this tracepoint (or perhaps a third
>> one). sys_rt_sigtimedwait "gets" a signal without delivering it. In
>> POSIX terminology this is called "accepting" the signal: the three
>> things that can happen in the life of a signal are "generate",
>> "deliver", and "accept". If you are trying to match up what happened
>> to a signal generated by kill() or whatnot, then you want to notice
>> both delivery and acceptance as the complementary event.
>>
>> (And again I have no clue why this signal stuff should be called
>> "sched" at all.)
>
> it shouldnt be called 'sched' - it should go into 'events/signal.h'.
>
> But we also need fuller coverage than this. Coredumps and signal
> delivery events are just a small part of all things signals, we also
> want:
That's a good idea. I'll put coredump and signal related events
into events/signal.h.
>
> - signal generation events (send_sig*() variants)
Those events finally calls __send_signal(), so I think
trace_signal_send() can trace those events.
> - signal IPI/wakeup events
All signals might be used for IPI, isn't it? :-)
Or, did you mean SIGSTOP/SIGCONT pare?
> - signal loss events (queue overflow)
Perhaps, this event is only for rt-signals, since
legacy signals just overwritten if it was sent.
Thank you,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2009-11-16 21:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 22:52 [PATCH -tip 1/3] Pass mm->flags to binfmt core_dump for bitflag consistency Masami Hiramatsu
2009-11-13 22:52 ` [PATCH -tip 2/3] Add coredump tracepoint Masami Hiramatsu
2009-11-13 23:39 ` Roland McGrath
2009-11-14 0:00 ` Masami Hiramatsu
2009-11-14 0:02 ` Ingo Molnar
2009-11-14 0:06 ` Roland McGrath
2009-11-14 0:14 ` Ingo Molnar
2009-11-14 1:49 ` Roland McGrath
2009-11-14 0:26 ` Masami Hiramatsu
2009-11-13 22:52 ` [PATCH -tip 3/3] Add get_signal tracepoint Masami Hiramatsu
2009-11-13 23:53 ` Roland McGrath
2009-11-14 0:12 ` Ingo Molnar
2009-11-16 21:52 ` Masami Hiramatsu [this message]
2009-11-16 22:11 ` Roland McGrath
2009-11-16 22:40 ` Masami Hiramatsu
2009-11-16 23:01 ` Roland McGrath
2009-11-16 23:46 ` Masami Hiramatsu
2009-11-17 6:03 ` Ingo Molnar
2009-11-17 15:25 ` Masami Hiramatsu
2009-11-14 0:29 ` Masami Hiramatsu
2009-11-13 23:09 ` [PATCH -tip 1/3] Pass mm->flags to binfmt core_dump for bitflag consistency Andrew Morton
2009-11-13 23:25 ` Ingo Molnar
2009-11-13 23:45 ` Masami Hiramatsu
2009-11-13 23:16 ` Roland McGrath
2009-11-13 23:23 ` Ingo Molnar
2009-11-13 23:30 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B01C95B.1070302@redhat.com \
--to=mhiramat@redhat.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).