From: "fche at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/13536] New: staprun -u race condition
Date: Wed, 21 Dec 2011 18:41:00 -0000 [thread overview]
Message-ID: <bug-13536-6586@http.sourceware.org/bugzilla/> (raw)
http://sourceware.org/bugzilla/show_bug.cgi?id=13536
Bug #: 13536
Summary: staprun -u race condition
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: runtime
AssignedTo: systemtap@sourceware.org
ReportedBy: fche@redhat.com
Classification: Unclassified
When staprun -u/PATH is used, staprun.c:enable_uprobes() first checks
if uprobes is already in the kernel (via a hacky grep on /proc/kallsyms;
see commit 14fe042), and if that fails, it tries to insert_module the
given bad boy. This is racy, and can result in errors such as
Error inserting module '/tmp/staphDa9p3/uprobes/uprobes.ko': File exists
WARNING: /notnfs/INST/bin/staprun exited with status: 1
Pass 5: run failed. Try again with another '--vp 00001' option.
It's better to try and fail, than to race.
Since bug #5163, $prefix/share/systemtap/runtime/uprobes/* is never
built, so actually staprun -u (without the /path) will not generally
work. So testsuite/.../buildid.exp needs to be updated not to muck
with -u.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
next reply other threads:[~2011-12-21 17:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 18:41 fche at redhat dot com [this message]
2011-12-21 19:41 ` [Bug runtime/13536] " fche at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-13536-6586@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).