* [Bug runtime/13536] New: staprun -u race condition
@ 2011-12-21 18:41 fche at redhat dot com
2011-12-21 19:41 ` [Bug runtime/13536] " fche at redhat dot com
0 siblings, 1 reply; 2+ messages in thread
From: fche at redhat dot com @ 2011-12-21 18:41 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13536
Bug #: 13536
Summary: staprun -u race condition
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: runtime
AssignedTo: systemtap@sourceware.org
ReportedBy: fche@redhat.com
Classification: Unclassified
When staprun -u/PATH is used, staprun.c:enable_uprobes() first checks
if uprobes is already in the kernel (via a hacky grep on /proc/kallsyms;
see commit 14fe042), and if that fails, it tries to insert_module the
given bad boy. This is racy, and can result in errors such as
Error inserting module '/tmp/staphDa9p3/uprobes/uprobes.ko': File exists
WARNING: /notnfs/INST/bin/staprun exited with status: 1
Pass 5: run failed. Try again with another '--vp 00001' option.
It's better to try and fail, than to race.
Since bug #5163, $prefix/share/systemtap/runtime/uprobes/* is never
built, so actually staprun -u (without the /path) will not generally
work. So testsuite/.../buildid.exp needs to be updated not to muck
with -u.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug runtime/13536] staprun -u race condition
2011-12-21 18:41 [Bug runtime/13536] New: staprun -u race condition fche at redhat dot com
@ 2011-12-21 19:41 ` fche at redhat dot com
0 siblings, 0 replies; 2+ messages in thread
From: fche at redhat dot com @ 2011-12-21 19:41 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13536
Frank Ch. Eigler <fche at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> 2011-12-21 18:40:47 UTC ---
commit a53e79a
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-21 18:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-21 18:41 [Bug runtime/13536] New: staprun -u race condition fche at redhat dot com
2011-12-21 19:41 ` [Bug runtime/13536] " fche at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).