* [Bug runtime/13654] New: permit begin/end probes to sleep
@ 2012-02-02 15:45 fche at redhat dot com
2012-02-02 15:50 ` [Bug runtime/13654] " fche at redhat dot com
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: fche at redhat dot com @ 2012-02-02 15:45 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13654
Bug #: 13654
Summary: permit begin/end probes to sleep
Product: systemtap
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: runtime
AssignedTo: systemtap@sourceware.org
ReportedBy: fche@redhat.com
Blocks: 13641
Classification: Unclassified
It is sometimes desirable (bug #13641) to permit embedded-C code to
sleep, when not otherwise precluded by the invoking kernel context.
This may include nothing other than begin/end type probes. However,
our general probe handler prologue does:
static void enter_be_probe (struct stap_be_probe *stp) {
...
#if INTERRUPTIBLE
preempt_disable ();
#else
local_irq_save (flags);
#endif
...
which makes might_sleep() contents unsafe. Sure, removing these lines
is an option, but then suddenly the various runtime code that assumes
that it's being invoked preemption-free (and thus may safely use
smp_processor_id()) has to be fixed. They could instead take the
CONTEXT* from from the probe handler, where by the way we could as
well store whatever per-cpu transport gunk is currently being
indexed.
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug runtime/13654] permit begin/end probes to sleep
2012-02-02 15:45 [Bug runtime/13654] New: permit begin/end probes to sleep fche at redhat dot com
2012-02-02 15:50 ` [Bug runtime/13654] " fche at redhat dot com
@ 2012-02-02 15:50 ` f-turgis at ti dot com
2012-02-02 15:53 ` fche at redhat dot com
2012-03-19 14:52 ` fche at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: f-turgis at ti dot com @ 2012-02-02 15:50 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13654
Frederic Turgis <f-turgis at ti dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |f-turgis at ti dot com
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug runtime/13654] permit begin/end probes to sleep
2012-02-02 15:45 [Bug runtime/13654] New: permit begin/end probes to sleep fche at redhat dot com
@ 2012-02-02 15:50 ` fche at redhat dot com
2012-02-02 15:50 ` f-turgis at ti dot com
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: fche at redhat dot com @ 2012-02-02 15:50 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13654
Frank Ch. Eigler <fche at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |10124
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug runtime/13654] permit begin/end probes to sleep
2012-02-02 15:45 [Bug runtime/13654] New: permit begin/end probes to sleep fche at redhat dot com
2012-02-02 15:50 ` [Bug runtime/13654] " fche at redhat dot com
2012-02-02 15:50 ` f-turgis at ti dot com
@ 2012-02-02 15:53 ` fche at redhat dot com
2012-03-19 14:52 ` fche at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: fche at redhat dot com @ 2012-02-02 15:53 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13654
--- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> 2012-02-02 15:51:39 UTC ---
By the way, some credit is due Martin Hunt (formerly hunt@redhat.com)
who long ago pointed out a problem of probe-end's being unable to sleep.
It interferes with the ability to produce long reports (due to limited
buffer sizes, and the inability to context-switch to stapio to consume
the data on the go).
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug runtime/13654] permit begin/end probes to sleep
2012-02-02 15:45 [Bug runtime/13654] New: permit begin/end probes to sleep fche at redhat dot com
` (2 preceding siblings ...)
2012-02-02 15:53 ` fche at redhat dot com
@ 2012-03-19 14:52 ` fche at redhat dot com
3 siblings, 0 replies; 5+ messages in thread
From: fche at redhat dot com @ 2012-03-19 14:52 UTC (permalink / raw)
To: systemtap
http://sourceware.org/bugzilla/show_bug.cgi?id=13654
--- Comment #2 from Frank Ch. Eigler <fche at redhat dot com> 2012-03-19 14:50:08 UTC ---
*** Bug 10202 has been marked as a duplicate of this bug. ***
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-19 14:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-02 15:45 [Bug runtime/13654] New: permit begin/end probes to sleep fche at redhat dot com
2012-02-02 15:50 ` [Bug runtime/13654] " fche at redhat dot com
2012-02-02 15:50 ` f-turgis at ti dot com
2012-02-02 15:53 ` fche at redhat dot com
2012-03-19 14:52 ` fche at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).