[Bug runtime/13654] New: permit begin/end probes to sleep

[Bug runtime/13654] New: permit begin/end probes to sleep

[fche at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13654

             Bug #: 13654
           Summary: permit begin/end probes to sleep
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
        AssignedTo: systemtap@sourceware.org
        ReportedBy: fche@redhat.com
            Blocks: 13641
    Classification: Unclassified


It is sometimes desirable (bug #13641) to permit embedded-C code to
sleep, when not otherwise precluded by the invoking kernel context.
This may include nothing other than begin/end type probes.  However,
our general probe handler prologue does:

static void enter_be_probe (struct stap_be_probe *stp) {
 ...
  #if INTERRUPTIBLE
  preempt_disable ();
  #else
  local_irq_save (flags);
  #endif
 ...

which makes might_sleep() contents unsafe.  Sure, removing these lines
is an option, but then suddenly the various runtime code that assumes
that it's being invoked preemption-free (and thus may safely use
smp_processor_id()) has to be fixed.  They could instead take the
CONTEXT* from from the probe handler, where by the way we could as
well store whatever per-cpu transport gunk is currently being
indexed.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug runtime/13654] permit begin/end probes to sleep

[f-turgis at ti dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13654

Frederic Turgis <f-turgis at ti dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |f-turgis at ti dot com

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug runtime/13654] permit begin/end probes to sleep

[fche at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13654

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10124

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug runtime/13654] permit begin/end probes to sleep

[fche at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13654

--- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> 2012-02-02 15:51:39 UTC ---
By the way, some credit is due Martin Hunt (formerly hunt@redhat.com)
who long ago pointed out a problem of probe-end's being unable to sleep.
It interferes with the ability to produce long reports (due to limited
buffer sizes, and the inability to context-switch to stapio to consume
the data on the go).

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug runtime/13654] permit begin/end probes to sleep

[fche at redhat dot com]

http://sourceware.org/bugzilla/show_bug.cgi?id=13654

--- Comment #2 from Frank Ch. Eigler <fche at redhat dot com> 2012-03-19 14:50:08 UTC ---
*** Bug 10202 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.