[Bug runtime/22158] New: on rawhide, we're getting a compile error that spin_unlock_wait() doesn't exist

[Bug runtime/22158] New: on rawhide, we're getting a compile error that spin_unlock_wait() doesn't exist

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22158

            Bug ID: 22158
           Summary: on rawhide, we're getting a compile error that
                    spin_unlock_wait() doesn't exist
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: dsmith at redhat dot com
  Target Milestone: ---

On rawhide (4.14.0-0.rc0.git6.1.fc28.x86_64+debug), systemtap can no longer
build a module, because of the following errors:

====
# stap -e 'probe begin { exit() }'
In file included from /usr/local/share/systemtap/runtime/stp_utrace.c:30:0,
                 from
/usr/local/share/systemtap/runtime/linux/task_finder2.c:4,
                 from
/usr/local/share/systemtap/runtime/linux/task_finder.c:17,
                 from /usr/local/share/systemtap/runtime/linux/runtime.h:222,
                 from /usr/local/share/systemtap/runtime/runtime.h:26,
                 from
/tmp/stapdpP91a/stap_e2c777d95e6fc0004ae87e12eb604984_1116_src.c:25:
/usr/local/share/systemtap/runtime/stp_helper_lock.h: In function
‘stp_spin_unlock_wait’:
/usr/local/share/systemtap/runtime/stp_helper_lock.h:60:61: error: implicit
declaration of function ‘spin_unlock_wait’; did you mean
‘stp_spin_unlock_wait’? [-Werror=implicit-function-declaration]
 static inline void stp_spin_unlock_wait(spinlock_t *lock) {
spin_unlock_wait(lock); }
                                                             ^~~~~~~~~~~~~~~~
                                                            
stp_spin_unlock_wait
cc1: all warnings being treated as errors
make[1]: *** [scripts/Makefile.build:311:
/tmp/stapdpP91a/stap_e2c777d95e6fc0004ae87e12eb604984_1116_src.o] Error 1
make: *** [Makefile:1516: _module_/tmp/stapdpP91a] Error 2
WARNING: kbuild exited with status: 2
Pass 4: compilation failed.  [man error::pass4]
====

This is because the following upstream kernel commit removed
spin_unlock_wait():

====
commit d3a024abbc438277851c510b51ec9b158821488b
Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Date:   Thu Jun 29 15:47:44 2017 -0700

    locking: Remove spin_unlock_wait() generic definitions

    There is no agreed-upon definition of spin_unlock_wait()'s semantics,
    and it appears that all callers could do just as well with a lock/unlock
    pair.  This commit therefore removes spin_unlock_wait() and related
    definitions from core code.
====

The systemtap runtime should be updated.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug runtime/22158] on rawhide, we're getting a compile error that spin_unlock_wait() doesn't exist

[dsmith at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22158

David Smith <dsmith at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from David Smith <dsmith at redhat dot com> ---
Fixed in commit 0643ca2b7.

-- 
You are receiving this mail because:
You are the assignee for the bug.