public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "wcohen at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/31074] On aarch64 the systemtap.base/set_kernel.stp triggers "Unable to handle kernel paging request"
Date: Wed, 22 Nov 2023 15:02:19 +0000	[thread overview]
Message-ID: <bug-31074-6586-Fw5xN0i75A@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31074-6586@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31074

William Cohen <wcohen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from William Cohen <wcohen at redhat dot com> ---
Yes, it looked like the value might NULL + offset for field.  Added "-g
-save-temps" to EXTRA_CFLAGS of the make file of the save /tmp/stap* to get a
better idea of what the compiler is generating for code and where things are
located.

for the get_buffer:
        adrp    x3, .LANCHOR0
        add     x3, x3, :lo12:.LANCHOR0
        add     x3, x3, 568
        mov     x2, 512
        mov     x0, x3
        mov     w1, 0
.LVL175:
        .loc 23 1963 178 discriminator 1 view .LVU775
        bl      memset

get_tracepoint (static tracepoint_table)

.LVL489:
        .loc 27 127 36 view .LVU2068
        adrp    x1, .LANCHOR0
        add     x1, x1, :lo12:.LANCHOR0
        add     x1, x1, 1080
        ldr     x19, [x1, x0, lsl 3]

One thought that crossed my mind is that the memset code is pretty optimized
using cacheline zeroing for specific memset(x, 0, size) operations and might be
overrunning the end the static buffer into the static tracepoint_table as
buffer is not aligned to cache boundaries.  However, reducing the size of the
get_buffer memset clearing didn't eliminate the problem.

Thinking probably should add some diagnostics to the stp_tracepoint.c to get a
better understanding how tracepoint_table entries are getting corrupted.

-- 
You are receiving this mail because:
You are the assignee for the bug.

  parent reply	other threads:[~2023-11-22 15:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17 17:13 [Bug runtime/31074] New: " wcohen at redhat dot com
2023-11-22  0:19 ` [Bug runtime/31074] " fche at redhat dot com
2023-11-22 15:02 ` wcohen at redhat dot com [this message]
2023-11-22 15:36 ` fche at redhat dot com
2023-11-27 16:07 ` wcohen at redhat dot com
2023-12-01 14:51 ` wcohen at redhat dot com
2023-12-01 16:45 ` wcohen at redhat dot com
2023-12-01 17:19 ` mark at klomp dot org
2023-12-04 16:38 ` wcohen at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31074-6586-Fw5xN0i75A@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).