From: "wcohen at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/31074] On aarch64 the systemtap.base/set_kernel.stp triggers "Unable to handle kernel paging request"
Date: Mon, 04 Dec 2023 16:38:24 +0000 [thread overview]
Message-ID: <bug-31074-6586-QS1iPbfdMq@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31074-6586@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=31074
William Cohen <wcohen at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #8 from William Cohen <wcohen at redhat dot com> ---
Fixed by
commit b84a5e8c2c5a857c0790a71df7824259a95131cf (HEAD -> master, origin/master,
origin/HEAD)
Author: William Cohen <wcohen@redhat.com>
Date: Mon Dec 4 11:28:10 2023 -0500
PR31074: Ensure that the set_kernel_string* functions limit their writes
Both the set_kernel_string and set_kernel_string_n function use the
underlying _stp_store_deref_string_ function to write strings. There
were two issues with the this function:
1) wrote MAXSTRINGLEN bytes even if string was shorter
2) null write at end could spill past end of buffer
The first issue was addressed by stopping to write once a null
character is encountered. The second issue is a side effect of C
implicit promotion of character constants to ints and was addressed by
explicitlying casting the character constants as a char.
The pr31074.exp test was added to verify that the write length are
limited to string length and the null write does not go beyond the end
of the buffer.
--
You are receiving this mail because:
You are the assignee for the bug.
prev parent reply other threads:[~2023-12-04 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 17:13 [Bug runtime/31074] New: " wcohen at redhat dot com
2023-11-22 0:19 ` [Bug runtime/31074] " fche at redhat dot com
2023-11-22 15:02 ` wcohen at redhat dot com
2023-11-22 15:36 ` fche at redhat dot com
2023-11-27 16:07 ` wcohen at redhat dot com
2023-12-01 14:51 ` wcohen at redhat dot com
2023-12-01 16:45 ` wcohen at redhat dot com
2023-12-01 17:19 ` mark at klomp dot org
2023-12-04 16:38 ` wcohen at redhat dot com [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-31074-6586-QS1iPbfdMq@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).