public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "wcohen at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/31117] transport failures
Date: Thu, 04 Jan 2024 22:34:06 +0000	[thread overview]
Message-ID: <bug-31117-6586-L8BcwGljpi@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31117-6586@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31117

--- Comment #5 from William Cohen <wcohen at redhat dot com> ---
Created attachment 15285
  --> https://sourceware.org/bugzilla/attachment.cgi?id=15285&action=edit
Patch reduce transport drops

The patch retries reserving space if it gets to the end of a subbuffer and
there isn't enough room for the header.  There probably needs to be some tweaks
to the code in staprun/relay.c to not count the padding as lost bytes when it
is looking for the the STAP_TRACE_MAGIC.

The attached patch improves the test results for the systemtap.map tests that
were transporting more than PAGE_SIZE amount of data.  It also improves the
test results for the syscall tests.

For:

sudo make installcheck RUNTESTFLAGS="systemtap.maps/*.exp"

Before the patch:

                === systemtap Summary ===

# of expected passes            83
# of unexpected failures        6
# of unsupported tests          1

                === systemtap Summary ===

# of expected passes            86
# of unexpected failures        3
# of unsupported tests          1

@@ -106 +95 @@
-FAIL: systemtap.maps/map_hash_SSI.stp
+PASS: systemtap.maps/map_hash_SSI.stp
@@ -108 +97 @@
-FAIL: systemtap.maps/map_hash_stat_II.stp
+PASS: systemtap.maps/map_hash_stat_II.stp
@@ -110 +99 @@
-FAIL: systemtap.maps/map_hash_stat_SI.stp
+PASS: systemtap.maps/map_hash_stat_SI.stp


The syscall test results look much better also.  However, on RHEL9/f39 there
are a number of unrelated failures on x86_64 for the 32-bit tests because the
check for the syscall names/numbers added by git commit
7fe1b7bb8e665c9edd38eaf34a499618ee763293

-- 
You are receiving this mail because:
You are the assignee for the bug.

  parent reply	other threads:[~2024-01-04 22:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06 15:39 [Bug runtime/31117] New: " mcermak at redhat dot com
2023-12-06 21:17 ` [Bug runtime/31117] " wcohen at redhat dot com
2023-12-13 21:27 ` mcermak at redhat dot com
2023-12-14 20:23 ` wcohen at redhat dot com
2023-12-18 18:55 ` wcohen at redhat dot com
2023-12-21 21:43 ` wcohen at redhat dot com
2024-01-04 22:34 ` wcohen at redhat dot com [this message]
2024-01-05 14:50 ` mcermak at redhat dot com
2024-01-05 15:21 ` mcermak at redhat dot com
2024-01-08 14:56 ` wcohen at redhat dot com
2024-01-09 12:11 ` mcermak at redhat dot com
2024-01-10 12:37 ` mcermak at redhat dot com
2024-01-22 15:54 ` wcohen at redhat dot com
2024-01-23 18:24 ` wcohen at redhat dot com
2024-02-02 15:07 ` mcermak at redhat dot com
2024-02-02 15:15 ` mcermak at redhat dot com
2024-02-05 15:32 ` wcohen at redhat dot com
2024-03-04 16:52 ` wcohen at redhat dot com
2024-03-04 21:30 ` wcohen at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31117-6586-L8BcwGljpi@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).