public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "wcohen at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sourceware.org
Subject: [Bug runtime/31117] transport failures
Date: Mon, 04 Mar 2024 21:30:59 +0000	[thread overview]
Message-ID: <bug-31117-6586-hmK0ZyiK2w@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-31117-6586@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=31117

William Cohen <wcohen at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #17 from William Cohen <wcohen at redhat dot com> ---
This PR should be addressed by:

commit d1b74b12acc07f52c7d8f5b080176c485c34cd63 (HEAD -> master, origin/master,
origin/HEAD)
Author: William Cohen <wcohen@redhat.com>
Date:   Mon Mar 4 16:27:18 2024 -0500

    PR31117: Correct handling of transport layer allocated memory

    The _stp_print_flush() code was not correct.  There are four possible
    ranges of values compared to the header size (hlen)
    _stp_data_write_reserve() could return when beginning to write out
    log:

    <0      unable to allocate any space
    <hlen   pad out the allocated space and try another allocation
    ==hlen  just enough space for the initial header
    >hlen   write out the header and some portion of log

    The case where the space allocated was equal size of the header
    (==hlen) was not handled correctly.  In the cases where there was only
    enough room to write the header the _stp_transport_failures variable
    was incremented and none of the log data was written out.  The correct
    course of action in these cases would be to write the header out in
    the allocated space and start looping to write the rest of the log
    data.

-- 
You are receiving this mail because:
You are the assignee for the bug.

      parent reply	other threads:[~2024-03-04 21:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06 15:39 [Bug runtime/31117] New: " mcermak at redhat dot com
2023-12-06 21:17 ` [Bug runtime/31117] " wcohen at redhat dot com
2023-12-13 21:27 ` mcermak at redhat dot com
2023-12-14 20:23 ` wcohen at redhat dot com
2023-12-18 18:55 ` wcohen at redhat dot com
2023-12-21 21:43 ` wcohen at redhat dot com
2024-01-04 22:34 ` wcohen at redhat dot com
2024-01-05 14:50 ` mcermak at redhat dot com
2024-01-05 15:21 ` mcermak at redhat dot com
2024-01-08 14:56 ` wcohen at redhat dot com
2024-01-09 12:11 ` mcermak at redhat dot com
2024-01-10 12:37 ` mcermak at redhat dot com
2024-01-22 15:54 ` wcohen at redhat dot com
2024-01-23 18:24 ` wcohen at redhat dot com
2024-02-02 15:07 ` mcermak at redhat dot com
2024-02-02 15:15 ` mcermak at redhat dot com
2024-02-05 15:32 ` wcohen at redhat dot com
2024-03-04 16:52 ` wcohen at redhat dot com
2024-03-04 21:30 ` wcohen at redhat dot com [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-31117-6586-hmK0ZyiK2w@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).