public inbox for test-list@sourceware.org
help / color / mirror / Atom feed
From: Guinevere Larsen <blarsen@redhat.com>
To: Guinevere Larsen <blarsen@redhat.com>, test-list@sourceware.org
Subject: Re: [PATCH] updating maintainers. Squash in future
Date: Tue, 3 Oct 2023 16:07:02 +0200	[thread overview]
Message-ID: <558d98ea-f397-4302-b040-417bd9c4845e@redhat.com> (raw)
In-Reply-To: <20231003140011.191160-2-blarsen@redhat.com>

On 03/10/2023 16:00, Guinevere Larsen wrote:
> This is a test patch to see if b4 can handle a git trailer with
> parenthesis at the end

Well I can't test this without a tag, now can I?

Reviewed-By: Guinevere Larsen <blarsen@redhat.com> (code)

-- 
Cheers,
Guinevere Larsen
She/Her/Hers

>
> ---
>   gdb/MAINTAINERS | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS
> index 0286bf4ac4a..dd11d0e6b12 100644
> --- a/gdb/MAINTAINERS
> +++ b/gdb/MAINTAINERS
> @@ -88,13 +88,6 @@ trailers are used to identify who contributed and how.  All patches pushed
>   upstream should have at least one Approved-By patches (with the exception of
>   obvious patches, see below).  The trailers (or tags) currently in use are:
>   
> - - Acked-By:
> -
> -   Used when a contributor has taken a quick glance at a patch and agrees
> -   with the direction outlined in the commit message, but hasn't evaluated
> -   the code for correctness or regressions.
> -   Usage: "Acked-By: Your Name <your@email>"
> -
>    - Tested-by:
>   
>      Used when a contributor has tested the patch and finds that it
> @@ -111,6 +104,13 @@ obvious patches, see below).  The trailers (or tags) currently in use are:
>      feel comfortable approving the patch.
>      Usage: "Reviewed-By: Your Name <your@email>"
>   
> + - Acked-By:
> +
> +   Used by a responsible or global maintainer when the patch touches multiple
> +   areas of GDB, but the maintainer does not want or is not able to approve
> +   all of them. When using this tag, add the area(s) at the end of the text.
> +   Usage: "Acked-By: Your Name <your@email> (area)"
> +
>    - Approved-by:
>   
>      Used by responsible maintainers or global maintainers when a patch is


      reply	other threads:[~2023-10-03 14:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03 14:00 Guinevere Larsen
2023-10-03 14:07 ` Guinevere Larsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558d98ea-f397-4302-b040-417bd9c4845e@redhat.com \
    --to=blarsen@redhat.com \
    --cc=test-list@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).