public inbox for test-list@sourceware.org
help / color / mirror / Atom feed
* [PATCH] updating maintainers. Squash in future
@ 2023-10-03 14:00 Guinevere Larsen
  2023-10-03 14:07 ` Guinevere Larsen
  0 siblings, 1 reply; 2+ messages in thread
From: Guinevere Larsen @ 2023-10-03 14:00 UTC (permalink / raw)
  To: test-list; +Cc: Guinevere Larsen

This is a test patch to see if b4 can handle a git trailer with
parenthesis at the end

---
 gdb/MAINTAINERS | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS
index 0286bf4ac4a..dd11d0e6b12 100644
--- a/gdb/MAINTAINERS
+++ b/gdb/MAINTAINERS
@@ -88,13 +88,6 @@ trailers are used to identify who contributed and how.  All patches pushed
 upstream should have at least one Approved-By patches (with the exception of
 obvious patches, see below).  The trailers (or tags) currently in use are:
 
- - Acked-By:
-
-   Used when a contributor has taken a quick glance at a patch and agrees
-   with the direction outlined in the commit message, but hasn't evaluated
-   the code for correctness or regressions.
-   Usage: "Acked-By: Your Name <your@email>"
-
  - Tested-by:
 
    Used when a contributor has tested the patch and finds that it
@@ -111,6 +104,13 @@ obvious patches, see below).  The trailers (or tags) currently in use are:
    feel comfortable approving the patch.
    Usage: "Reviewed-By: Your Name <your@email>"
 
+ - Acked-By:
+
+   Used by a responsible or global maintainer when the patch touches multiple
+   areas of GDB, but the maintainer does not want or is not able to approve
+   all of them. When using this tag, add the area(s) at the end of the text.
+   Usage: "Acked-By: Your Name <your@email> (area)"
+
  - Approved-by:
 
    Used by responsible maintainers or global maintainers when a patch is
-- 
2.41.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] updating maintainers. Squash in future
  2023-10-03 14:00 [PATCH] updating maintainers. Squash in future Guinevere Larsen
@ 2023-10-03 14:07 ` Guinevere Larsen
  0 siblings, 0 replies; 2+ messages in thread
From: Guinevere Larsen @ 2023-10-03 14:07 UTC (permalink / raw)
  To: Guinevere Larsen, test-list

On 03/10/2023 16:00, Guinevere Larsen wrote:
> This is a test patch to see if b4 can handle a git trailer with
> parenthesis at the end

Well I can't test this without a tag, now can I?

Reviewed-By: Guinevere Larsen <blarsen@redhat.com> (code)

-- 
Cheers,
Guinevere Larsen
She/Her/Hers

>
> ---
>   gdb/MAINTAINERS | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS
> index 0286bf4ac4a..dd11d0e6b12 100644
> --- a/gdb/MAINTAINERS
> +++ b/gdb/MAINTAINERS
> @@ -88,13 +88,6 @@ trailers are used to identify who contributed and how.  All patches pushed
>   upstream should have at least one Approved-By patches (with the exception of
>   obvious patches, see below).  The trailers (or tags) currently in use are:
>   
> - - Acked-By:
> -
> -   Used when a contributor has taken a quick glance at a patch and agrees
> -   with the direction outlined in the commit message, but hasn't evaluated
> -   the code for correctness or regressions.
> -   Usage: "Acked-By: Your Name <your@email>"
> -
>    - Tested-by:
>   
>      Used when a contributor has tested the patch and finds that it
> @@ -111,6 +104,13 @@ obvious patches, see below).  The trailers (or tags) currently in use are:
>      feel comfortable approving the patch.
>      Usage: "Reviewed-By: Your Name <your@email>"
>   
> + - Acked-By:
> +
> +   Used by a responsible or global maintainer when the patch touches multiple
> +   areas of GDB, but the maintainer does not want or is not able to approve
> +   all of them. When using this tag, add the area(s) at the end of the text.
> +   Usage: "Acked-By: Your Name <your@email> (area)"
> +
>    - Approved-by:
>   
>      Used by responsible maintainers or global maintainers when a patch is


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-10-03 14:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-03 14:00 [PATCH] updating maintainers. Squash in future Guinevere Larsen
2023-10-03 14:07 ` Guinevere Larsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).