[delayed-symfile] [commit] Fix objfile_relocate

[delayed-symfile] [commit] Fix objfile_relocate

[Jan Kratochvil]

850378e2d04b910f0541aa67e8fa5f990b6e35ba Mon Sep 17 00:00:00 2001
From: Jan Kratochvil <jkratoch@host1.dyn.jankratochvil.net>
Date: Sun, 6 Dec 2009 22:02:22 +0100
Subject: [PATCH] Fix objfile_relocate for this branch.

	* objfiles.c (objfile_relocate): Call addrmap_relocate on quick_addrmap.

Testcase included in archer-jankratochvil-pie-fedora12 break-interp.exp .
---
 gdb/objfiles.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/gdb/objfiles.c b/gdb/objfiles.c
index 9c5f303..0f75ebd 100644
--- a/gdb/objfiles.c
+++ b/gdb/objfiles.c
@@ -633,6 +633,11 @@ objfile_relocate (struct objfile *objfile, struct section_offsets *new_offsets)
     }
   }
 
+  /* Alread QUICK_ADDRMAP tiself assumes all sections have the same offset.  */
+  if (objfile->quick_addrmap)
+    addrmap_relocate (objfile->quick_addrmap,
+		      ANOFFSET (delta, SECT_OFF_TEXT (objfile)));
+
   {
     struct partial_symbol **psym;
 
-- 
1.6.5.2

Re: [delayed-symfile] [commit] Fix objfile_relocate

[Tom Tromey]

Jan> 	* objfiles.c (objfile_relocate): Call addrmap_relocate on quick_addrmap.

Thanks.

Jan> +  /* Alread QUICK_ADDRMAP tiself assumes all sections have the same offset.  */

Two typos, "Already" and "itself".

Also, AFAICT gcc only emits text ranges in .debug_aranges.

Tom

Re: [delayed-symfile] [commit] Fix objfile_relocate

[Jan Kratochvil]

On Mon, 07 Dec 2009 18:50:41 +0100, Tom Tromey wrote:
> Jan> +  /* Alread QUICK_ADDRMAP tiself assumes all sections have the same offset.  */
> 
> Two typos, "Already" and "itself".
> 
> Also, AFAICT gcc only emits text ranges in .debug_aranges.

Later found at least dwarf2read.c already commonly assumes SECT_OFF_TEXT is
applicable to any types (/data/bss) of inferior objects.


Thanks,
Jan

aaeaa5944753c471599839b077635e4b3717d870
From: Jan Kratochvil <jkratoch@host1.dyn.jankratochvil.net>
Date: Tue, 8 Dec 2009 20:07:13 +0100
Subject: [PATCH] Drop <quick_addrmap> comment.

	* objfiles.c (objfile_relocate) <quick_addrmap>: Drop the comment.
---
 gdb/objfiles.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/gdb/objfiles.c b/gdb/objfiles.c
index 0f75ebd..2cd1001 100644
--- a/gdb/objfiles.c
+++ b/gdb/objfiles.c
@@ -633,7 +633,6 @@ objfile_relocate (struct objfile *objfile, struct section_offsets *new_offsets)
     }
   }
 
-  /* Alread QUICK_ADDRMAP tiself assumes all sections have the same offset.  */
   if (objfile->quick_addrmap)
     addrmap_relocate (objfile->quick_addrmap,
 		      ANOFFSET (delta, SECT_OFF_TEXT (objfile)));
-- 
1.6.5.2